Re: [quicwg/base-drafts] Clients use the same crypto handshake after Retry (#2746)
Kazuho Oku <notifications@github.com> Tue, 11 June 2019 05:20 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2D4B512023C for <quic-issues@ietfa.amsl.com>; Mon, 10 Jun 2019 22:20:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HuZxUNIYuIgR for <quic-issues@ietfa.amsl.com>; Mon, 10 Jun 2019 22:20:03 -0700 (PDT)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 692F11201D8 for <quic-issues@ietf.org>; Mon, 10 Jun 2019 22:20:03 -0700 (PDT)
Date: Mon, 10 Jun 2019 22:20:02 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560230402; bh=8PjCLcrx7fpI6n/xrDsWuJrnnK9V80j1FOxc2kYZ5A4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fZflkAOOrKikd4KBrpfbNbXB/aC2ElWwxYftK8Nsk06xjbcb1BnWPyV/aEnfBDxDT sqHvKuS+gD/m5A3afgnahDfnSoAf5GSsiJ/fqXQOlSvsIgHb+ObVyB1Z6sWs9cgkd9 rZTfTv2OJH6skG021puXI+LovyrV/z0Ub8sHflSY=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2QTJEBRO75MILRPFV3BRWIFEVBNHHBVJVVM4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2746/review/247955308@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2746@github.com>
References: <quicwg/base-drafts/pull/2746@github.com>
Subject: Re: [quicwg/base-drafts] Clients use the same crypto handshake after Retry (#2746)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cff3a025f32d_3f9a3fb06eccd964214182"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YNc6bBanq8j7G5azyzxPYr7cQ9Q>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jun 2019 05:20:10 -0000
kazuho commented on this pull request.
LGTM modulo the point below.
>
A client MAY attempt 0-RTT after receiving a Retry packet by sending 0-RTT
-packets to the connection ID provided by the server. A client that sends
-additional 0-RTT packets without constructing a new cryptographic handshake
-message MUST NOT reset the packet number to 0 after a Retry packet; see
-{{packet-0rtt}}.
+packets to the connection ID provided by the server. A client MUST NOT change
+the cryptographic handshake message it sends in response to receiving a Retry.
+
+A client MUST NOT reset the packet number to 0 for any packet number space after
Do we need to stay "to 0"?
I think it'd be better to just omit "to 0", because resetting the packet number does not necessary mean that it goes to zero. It is totally reasonable for an endpoint to start it's packet number from one.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2746#pullrequestreview-247955308
- [quicwg/base-drafts] Clients use the same crypto … Martin Thomson
- Re: [quicwg/base-drafts] Clients use the same cry… Marten Seemann
- Re: [quicwg/base-drafts] Clients use the same cry… Martin Thomson
- Re: [quicwg/base-drafts] Clients use the same cry… Martin Thomson
- Re: [quicwg/base-drafts] Clients use the same cry… Marten Seemann
- Re: [quicwg/base-drafts] Clients use the same cry… MikkelFJ
- Re: [quicwg/base-drafts] Clients use the same cry… Martin Thomson
- Re: [quicwg/base-drafts] Clients use the same cry… ianswett
- Re: [quicwg/base-drafts] Clients use the same cry… Kazuho Oku
- Re: [quicwg/base-drafts] Clients use the same cry… MikkelFJ
- Re: [quicwg/base-drafts] Clients use the same cry… Martin Thomson
- Re: [quicwg/base-drafts] Clients use the same cry… Martin Thomson