IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify what to do when ALPN negotiation fails (#2483)

Jana Iyengar <notifications@github.com> Wed, 06 March 2019 23:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6075312008A for <quic-issues@ietfa.amsl.com>; Wed, 6 Mar 2019 15:41:48 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EmCi22qy68Ic for <quic-issues@ietfa.amsl.com>; Wed, 6 Mar 2019 15:41:46 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2A0C9131222 for <quic-issues@ietf.org>; Wed, 6 Mar 2019 15:41:46 -0800 (PST)
Date: Wed, 06 Mar 2019 15:41:45 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1551915705; bh=QgHSoYw8ixMx3idQ14jYSMyI5BnkdSsraf1DbHBR4Ts=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=MiVHBRV3zk/gEgs1YWiGJWBVKHnvBRvq2YEUS8++AurNo8WQcoOodyENakLWdsnIV C2RN6PUTy6Jim6lKGHpg8WayZZ6F8mDJbR6DVs8hECzJaa3XsD/f8AChyvLAQRitKW 6QmQsDk2XdQ7ON7zRySK/q6VEd/Q+uIpLnGiJilE=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab97ec2860e10ae02ec1fe0b937a8a9478c046c84992cf0000000118981cb992a169ce18955108@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2483/review/211532794@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2483@github.com>
References: <quicwg/base-drafts/pull/2483@github.com>
Subject: Re: [quicwg/base-drafts] Clarify what to do when ALPN negotiation fails (#2483)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c805ab911d90_3fb43f934ead45b41611a8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YPhOgtohtHRZV-FkM4_KX5wR-Sc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Mar 2019 23:41:48 -0000

janaiyengar commented on this pull request.

a few nits

> @@ -1216,7 +1216,9 @@ negotiation.  TLS uses Application Layer Protocol Negotiation (ALPN)
 {{!RFC7301}} to select an application protocol.  Unless another mechanism is
 used for agreeing on an application protocol, endpoints MUST use ALPN for this
 purpose.  When using ALPN, endpoints MUST abort a connection if an application
-protocol is not negotiated.
+protocol is not negotiated with a no_application_protocol alert (error code
+0x178). While {{!RFC7301}} only specifies that servers use this alert, QUIC

```suggestion
0x178, see {{tls-errors}}).  While {{!RFC7301}} only specifies that servers use this alert, QUIC
```

> @@ -1216,7 +1216,9 @@ negotiation.  TLS uses Application Layer Protocol Negotiation (ALPN)
 {{!RFC7301}} to select an application protocol.  Unless another mechanism is
 used for agreeing on an application protocol, endpoints MUST use ALPN for this
 purpose.  When using ALPN, endpoints MUST abort a connection if an application
-protocol is not negotiated.
+protocol is not negotiated with a no_application_protocol alert (error code

```suggestion
protocol is not negotiated with a no_application_protocol TLS alert (QUIC error code
```

> @@ -1216,7 +1216,9 @@ negotiation.  TLS uses Application Layer Protocol Negotiation (ALPN)
 {{!RFC7301}} to select an application protocol.  Unless another mechanism is
 used for agreeing on an application protocol, endpoints MUST use ALPN for this
 purpose.  When using ALPN, endpoints MUST abort a connection if an application

```suggestion
purpose.  When using ALPN, endpoints MUST immediately close a connection (see Section 10.3 in {{QUIC-TRANSPORT}}) if an application
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2483#pullrequestreview-211532794

v2.19.0 | Report a Bug | By Email