IETF Logo Mail Archive

Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)

Martin Thomson <notifications@github.com> Wed, 06 February 2019 02:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 174FD128D09 for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 18:40:29 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -11.149
X-Spam-Level:
X-Spam-Status: No, score=-11.149 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MB6OC6gbi9RV for <quic-issues@ietfa.amsl.com>; Tue, 5 Feb 2019 18:40:27 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 92C0A126C7E for <quic-issues@ietf.org>; Tue, 5 Feb 2019 18:40:27 -0800 (PST)
Date: Tue, 05 Feb 2019 18:40:26 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549420826; bh=T+yC9EX2aABHuU9Y6Pmt132VPXIHBoic5fHDNcFO7Tk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JWO9+vgrY0qz1tEO8LCMKdUsYCgAWT/UEQQyG99bldovUStKIwFqd8s/DWBup8fQ7 oF0LH6ztWkoIoArFFY53wO1N3UN8DEwbDaJMe/uaNqsAXcj3hebxEJKIlhDIOinG9v t+SMBf6jDMakLYgAFLdoy1vb0OoNE1YJv8HTb2NQ=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9bb555df979e843a0c52f3d43a1e19bc748f598992cf0000000118720b1a92a169ce1842c3b7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2424/review/200395234@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2424@github.com>
References: <quicwg/base-drafts/pull/2424@github.com>
Subject: Re: [quicwg/base-drafts] Reword Immediate ACK Recommendation (#2424)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5a491a4182d_6d3d3f99fb2d45b849180"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YQWdZaDocNYQUJVgiT1yqO0UY6Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 02:40:29 -0000

martinthomson commented on this pull request.



> @@ -134,6 +134,11 @@ Crypto Packets:
 
 : Packets containing CRYPTO data sent in Initial or Handshake
   packets.
+  
+Out-of-order Packets:
+
+: Packets that do not increase the largest received packet number for its
+cryptographic context by exactly one.

I think that there are two cases we care about, I only caught the first

- an earlier packet was delayed - so there is a gap before this one
- this packet was delayed - and we already received a higher-numbered one

Maybe just: "Packets arrive out of order when packets are lost or delayed."  Which doesn't really capture all the reasons, but might suffice.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2424#discussion_r254122586

v2.30.2 | Report a Bug | By Email | System Status