IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)

Martin Thomson <notifications@github.com> Sun, 21 July 2019 01:06 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 53E6D120096 for <quic-issues@ietfa.amsl.com>; Sat, 20 Jul 2019 18:06:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.382
X-Spam-Level:
X-Spam-Status: No, score=-6.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5GkYnZhS6NTx for <quic-issues@ietfa.amsl.com>; Sat, 20 Jul 2019 18:06:36 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4A1CA12003F for <quic-issues@ietf.org>; Sat, 20 Jul 2019 18:06:36 -0700 (PDT)
Date: Sat, 20 Jul 2019 18:06:35 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563671195; bh=oa8F848Pp7NKDY/4+TmzJAIOtJhcSz77EPWhHphLaBQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0tLbHEOktIqdcgkEK/Iyy/wt07qgSJpR8Bttt8NFJ+6HWGvGTOwvMp8TYy8eR0qgT FSFlFSdJLzW4bIPH0OI8o/i0m/uIKSSbQ3W9EtjGQVRsBY0GMbDlq3RbOU8EPCaA9U Q/YHnqIGjWQwc3cqPTbzAqDH8tQ5GOFAzlz42SHo=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4DHRWOOUPZPUA3FKN3IDWRXEVBNHHBX66EHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2907/review/264516309@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2907@github.com>
References: <quicwg/base-drafts/pull/2907@github.com>
Subject: Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d33ba9b46bee_75673f9cb0ecd95c703494"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YQlDzxvADODmPTajyBP1MgUPsls>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jul 2019 01:06:38 -0000

martinthomson commented on this pull request.



>    if (no ack-eliciting packets in flight &&
-      (endpoint is server or has 1-RTT keys)):
+      (endpoint is server or has 1-RTT keys
+       or has received Handshake ACK)):

we should be consistent about || vs or and && vs and

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2907#pullrequestreview-264516309

v2.23.0 | Report a Bug | By Email