Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)

Bence Béky <notifications@github.com> Fri, 21 December 2018 15:11 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 426FE12DF71 for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 07:11:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.682
X-Spam-Level:
X-Spam-Status: No, score=-5.682 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tK5bz8T2HOXj for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 07:11:36 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EF522128D52 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 07:11:35 -0800 (PST)
Date: Fri, 21 Dec 2018 07:11:34 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545405094; bh=VtqkbcS5o5nAh5xOPi+xLxINcmzfkFIBogtOV0f7WDw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Eurl5WoExCdMH2ykzLukplMdWTrsPMowCECD8lyjp77HeV4rPptNEvkXPUqZWMCpD 8peyrItA7PyY2ggyYcwXvIO+BXG3uapJ+QGgI0I1wi3nyHln36e7tiqay6c0dntxk5 K9M1HPheQVlWIUeCioY5Ly3bZ4Q5ZwVgqA9Kn3jY=
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3b3a5bb02884f3ffaebb1cc86bad3f1add44241592cf000000011834c4a692a169ce1586350b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1763/review/187427640@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1763@github.com>
References: <quicwg/base-drafts/pull/1763@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: Encode Largest Reference modulo MaxEntries (#1763)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d02a683155_31fc3f84080d45b43932ad"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YRrxWzyHHlyYOS3ZiART3ZBifh0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 15:11:49 -0000

bencebeky commented on this pull request.



> @@ -149,7 +149,9 @@ peer's SETTINGS frame.
 
 Before a new entry is added to the dynamic table, entries are evicted from the
 end of the dynamic table until the size of the dynamic table is less than or
-equal to (maximum size - new entry size) or until the table is empty.
+equal to (maximum size - new entry size) or until the table is empty. The
+encoder MUST not evict a dynamic table entry unless it has first been

Technically, this does not forbid the encoder from referring to an entry on the request/push stream but only emitting it later on the encoder stream, which would of course be crazy but would mess with the Largest Reference wrapping algorithm.  I feel like some wordsmithing might be beneficial here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1763#discussion_r243606643