From nobody Thu Mar 12 14:57:29 2020
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 411AC3A080E
 for <quic-issues@ietfa.amsl.com>; Thu, 12 Mar 2020 14:57:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.041
X-Spam-Level: 
X-Spam-Status: No, score=-6.041 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_12=2.059, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id r7RQXPP5eqWp for <quic-issues@ietfa.amsl.com>;
 Thu, 12 Mar 2020 14:57:25 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id ADB0B3A07FF
 for <quic-issues@ietf.org>; Thu, 12 Mar 2020 14:57:25 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net
 (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47])
 by smtp.github.com (Postfix) with ESMTP id EAFC8C609F5
 for <quic-issues@ietf.org>; Thu, 12 Mar 2020 14:57:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1584050244;
 bh=G5Vi3sXDHqw8xDwCD2Vtc3SrudsHIGqM8V+Dh6w5y4g=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=KwCQnDqnBiuMygZfES8n3auRMp/XvWOn/Wm4umSUkHFkoOR2ChfRNePm5K97Bmu/B
 kCXTlzEXSePVkzwSVsq9Hj1v8dzg0ZfkpbKm002BEK6x5P7+RMwWH9vLz3Nb2B/Pu5
 DNb8KbyomXqs/7NkhUSHs1PggustvKtuaSjHTVog=
Date: Thu, 12 Mar 2020 14:57:24 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5WXZNLDZDZ6AVQC6F4O2IUJEVBNHHCFEGL6U@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3517/review/373929447@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3517@github.com>
References: <quicwg/base-drafts/pull/3517@github.com>
Subject: Re: [quicwg/base-drafts] should -> SHOULD when bundling ACK frames
 (#3517)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e6ab044dcf37_6fa83fb94d6cd964840f";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YYbV-H2xwkILDxNGdIteKS7B4Rs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Mar 2020 21:57:27 -0000


----==_mimepart_5e6ab044dcf37_6fa83fb94d6cd964840f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3517#pullrequestreview-373929447
----==_mimepart_5e6ab044dcf37_6fa83fb94d6cd964840f
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@martinthomson</b> approved this pull request.</p>



<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3517#pullrequestreview-373929447">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2ERBYK2235PWGCLVLRHFLEJANCNFSM4LGLPZWA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKYIAEWGLKEHT3UZWJTRHFLEJA5CNFSM4LGLPZWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCZE3LZY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3517#pullrequestreview-373929447",
"url": "https://github.com/quicwg/base-drafts/pull/3517#pullrequestreview-373929447",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e6ab044dcf37_6fa83fb94d6cd964840f--

