Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)

Martin Thomson <> Mon, 08 April 2019 00:57 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id E549912025F for <>; Sun, 7 Apr 2019 17:57:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id RgOqNJrCjTzt for <>; Sun, 7 Apr 2019 17:57:43 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 0CC2F12011A for <>; Sun, 7 Apr 2019 17:57:43 -0700 (PDT)
Date: Sun, 07 Apr 2019 17:57:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1554685061; bh=aeKlrkDQ7O3/f7v2ThEqdgPJrDp944+e9GD4zzmpwhA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Rvz1Wfd504R/JEue2L1X7y8FXX8ayS5UdifwixDrE9U3L5SMQlduyskNuPTHWBo5q AGB1hjtUdo2q3C45eowdzpaL1ToeNe56SoOZfX41QSFMZCAPKWRSMzzqdjaUxTAa6p 2I3Q79OreP3Mnc/eW2ctw3JDKKfKhWy01hDvcAHw=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/2281/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Include handshake anti-deadlock logic in pseudocode (#2281)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5caa9c858af1c_21cd3fd6c8ed45c0225868"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 08 Apr 2019 00:57:45 -0000

martinthomson commented on this pull request.

>      // Crypto retransmission timeout.
+  else if (endpoint is client without 1-RTT keys):
+    if (will send Initial packet):

Striking out the bit that we've agreed to remove, the text from the transport draft is:

> Clients MUST ensure that UDP datagrams containing Initial packets are sized to at least 1200 bytes, adding padding to packets in the datagram as necessary. ~~Once a client has received an acknowledgment for a Handshake packet it MAY send smaller datagrams.~~ Sending padded datagrams ensures that the server is not overly constrained by the amplification restriction.

This contradicts that text.  It's true that a server that received a Handshake packet is no longer subject to the anti-DoS limit on bytes transmitted, but it's a bit weird that we have an algorithm that directly contradicts a MUST-level requirement in the other document.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: