Date: Tue, 10 Dec 2019 18:30:32 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZ2Y5PBC6XXTY36OO537WDUREVBNHHB746W5E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3296/review/330266765@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3296@github.com>
References: <quicwg/base-drafts/pull/3296@github.com>
Subject: Re: [quicwg/base-drafts] Clarify conditions for disabling spin bit
 (#3296)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5df054c84f513_4d3f3fe2b6ccd96c962e1";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Yp2ewyJmnypY7sCkofDVLWYjges>


----==_mimepart_5df054c84f513_4d3f3fe2b6ccd96c962e1
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

janaiyengar approved this pull request.

One suggestion

> @@ -4380,12 +4380,10 @@ support the spin bit MUST implement it as specified in this section.
 Each endpoint unilaterally decides if the spin bit is enabled or disabled for a
 connection. Implementations MUST allow administrators of clients and servers
 to disable the spin bit either globally or on a per-connection basis. Even when
-the spin bit is not disabled by the administrator, implementations MUST disable
-the spin bit for a given connection with a certain likelihood. The random
-selection process SHOULD be designed such that on average the spin bit is
-disabled for at least one eighth of network paths. The selection process
-performed at the beginning of the connection SHOULD be applied for all paths
-used by the connection.
+the spin bit is not disabled by the administrator, endpoints MUST disable their
+use of the spin bit for a random selection of at least one in every 16 network
+paths, or for one in every 16 connection IDs. This ensures that the spin bit

```suggestion
paths, or for one in every 16 connection IDs. Since both endpoints in a connection disable the spin bit independently, this ensures that the spin bit
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3296#pullrequestreview-330266765
----==_mimepart_5df054c84f513_4d3f3fe2b6ccd96c962e1
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@janaiyengar</b> approved this pull request.</p>=0D
=0D
<p>One suggestion</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3296#discussi=
on_r356377121">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -4380,12 +4380,10 @@ support the spin b=
it MUST implement it as specified in this section.=0D
 Each endpoint unilaterally decides if the spin bit is enabled or disable=
d for a=0D
 connection. Implementations MUST allow administrators of clients and ser=
vers=0D
 to disable the spin bit either globally or on a per-connection basis. Ev=
en when=0D
-the spin bit is not disabled by the administrator, implementations MUST =
disable=0D
-the spin bit for a given connection with a certain likelihood. The rando=
m=0D
-selection process SHOULD be designed such that on average the spin bit i=
s=0D
-disabled for at least one eighth of network paths. The selection process=
=0D
-performed at the beginning of the connection SHOULD be applied for all p=
aths=0D
-used by the connection.=0D
+the spin bit is not disabled by the administrator, endpoints MUST disabl=
e their=0D
+use of the spin bit for a random selection of at least one in every 16 n=
etwork=0D
+paths, or for one in every 16 connection IDs. This ensures that the spin=
 bit=0D
</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-paths, or for one in every 16 connection IDs.=
 This ensures that the spin bit=0D
+paths, or for one in every 16 connection IDs. Since both endpoints in a =
connection disable the spin bit independently, this ensures that the spin=
 bit=0D
</pre>=0D
=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3296?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK6VD336YR4XTZBBGKDQYBGERA5CNFSM4JZG37Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOXXRDI#pullrequestreview-330266765=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK6RQPMRPMKE6BQRSYLQYBGERANCNFSM4JZG37YQ">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJKYDSIYUFMKZ=
TCDFG63QYBGERA5CNFSM4JZG37Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCOXXRDI.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3296?email_source=3D=
notifications\u0026email_token=3DAFTOJK6VD336YR4XTZBBGKDQYBGERA5CNFSM4JZG=
37Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
OXXRDI#pullrequestreview-330266765",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3296?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK6VD336YR4XTZBBGKDQYBGERA5CNFSM4JZG37=
Y2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOX=
XRDI#pullrequestreview-330266765",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5df054c84f513_4d3f3fe2b6ccd96c962e1--