IETF Logo Mail Archive

Re: [quicwg/base-drafts] Limit the size of packets (#501)

ianswett <notifications@github.com> Tue, 06 June 2017 14:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E62F3128DE7 for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 07:29:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.617
X-Spam-Level:
X-Spam-Status: No, score=-0.617 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z3iXc854yejP for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 07:29:16 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 70CF6129461 for <quic-issues@ietf.org>; Tue, 6 Jun 2017 07:29:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=P4L7oSJccqBhQbWqVXDGsIDN+EI=; b=VzAOVDnOZTOhAeHV 8r7XUHCo50L4Kfu4FMCoX8dwPfm47ru8SThiSNWbAu9ZNtupOyHrGuf58leCVGpp Ea0xjP58ZaiAxCSrh0l3cX82Hi+S2e2RcYB99ckEtz+Q7moSvIfMi21raPv+3p9c bELlnyY+He1aTt41L+9HcyA5SpM=
Received: by filter0850p1mdw1.sendgrid.net with SMTP id filter0850p1mdw1-13482-5936BC3A-29 2017-06-06 14:29:14.502754642 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id nrme7Qq1SkyRPFYcMGK9jw for <quic-issues@ietf.org>; Tue, 06 Jun 2017 14:29:14.501 +0000 (UTC)
Date: Tue, 06 Jun 2017 07:29:14 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7a9c542d834a21ba0009bf9619e1732cf6d34b2b92cf00000001154e7e3a92a169ce0d7b300d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/501/review/42333481@github.com>
In-Reply-To: <quicwg/base-drafts/pull/501@github.com>
References: <quicwg/base-drafts/pull/501@github.com>
Subject: Re: [quicwg/base-drafts] Limit the size of packets (#501)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5936bc3a6458d_43003fdb0e7abc2c227f0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0jwh7hcd/Z70qu46VwmJGDgZHA8Ojhd1ysmS v/5r3kaqBAOfqJEiOeRP0/lC7YRakhoYtlgolGxJojMzxGFBn7jp5ToVyWb89CTAAHsBCr4HlfAPbc Z5Nt827x6uszL5I+Q1KA+Zdr7Ri3Fxn/W3MWErtB3HP7rWnsmHBPFCUt79cWb3PtOQymcFpj5yyi/r A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YpDbdpyShkVJSZer_8dLCaTKy0I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2017 14:29:18 -0000

ianswett commented on this pull request.

Two nits

> @@ -1133,6 +1134,14 @@ truncate_connection_id (0x0004):
   length.  Omitting the parameter indicates that the endpoint relies on the
   connection ID being present in every packet.
 
+max_packet_size (0x0005):
+
+: The maximum packet size parameter places a limit on the size of packets that
+  the endpoint is willing to receive, encoded as an unsigned 16-bit integer.
+  The default for this parameter is the maximum permitted UDP payload of 65527.
+  Values below 256 are invalid.  The initial packet from a client is exempt from

1280 not 256?  Also, do we want to mention that the peer is indicating it will drop packets larger than the limit?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/501#pullrequestreview-42333481

v2.46.0 | Report a Bug | By Email | System Status