Re: [quicwg/base-drafts] Ipv6 flow label (#2399)

[Martin Thomson <[e-mail]>]

martinthomson approved this pull request.

Mostly good, though plenty of nits.  Let's get chair confirmation before merging though.

> @@ -2203,6 +2203,21 @@ address before path validation is complete.
 A client that migrates to a new address SHOULD use a preferred address from the
 same address family for the server.
 
+## Use of IPv6 Flow-Label and migration {ipv6-flow-label}

```suggestion
## Use of IPv6 Flow-Label and Migration {#ipv6-flow-label}
```

> @@ -2203,6 +2203,21 @@ address before path validation is complete.
 A client that migrates to a new address SHOULD use a preferred address from the
 same address family for the server.
 
+## Use of IPv6 Flow-Label and migration {ipv6-flow-label}
+
+Quic nodes that send data using IPv6 SHOULD document the IPv6 flow label

```suggestion
Endpoints that send data using IPv6 SHOULD apply an IPv6 flow label
```

> @@ -2203,6 +2203,21 @@ address before path validation is complete.
 A client that migrates to a new address SHOULD use a preferred address from the
 same address family for the server.
 
+## Use of IPv6 Flow-Label and migration {ipv6-flow-label}
+
+Quic nodes that send data using IPv6 SHOULD document the IPv6 flow label
+in compliance with {{!RFC6437}}, unless the local API does not allow
+setting this parameter.
+
+The IPv6 flow label should be a pseudo-random function of the source

```suggestion
The IPv6 flow label SHOULD be a pseudo-random function of the source
```

> @@ -2203,6 +2203,21 @@ address before path validation is complete.
 A client that migrates to a new address SHOULD use a preferred address from the
 same address family for the server.
 
+## Use of IPv6 Flow-Label and migration {ipv6-flow-label}
+
+Quic nodes that send data using IPv6 SHOULD document the IPv6 flow label
+in compliance with {{!RFC6437}}, unless the local API does not allow
+setting this parameter.
+
+The IPv6 flow label should be a pseudo-random function of the source
+and destination addresses, source and destination UDP ports, and the destination
+CID. The flow label generation MUST be designed to minimize the chances of
+collision with a previously used flow label, as this would enable linkability

```suggestion
linkability with a previously used flow label, as this would enable correlating activity on multiple paths
```

> @@ -2203,6 +2203,21 @@ address before path validation is complete.
 A client that migrates to a new address SHOULD use a preferred address from the
 same address family for the server.
 
+## Use of IPv6 Flow-Label and migration {ipv6-flow-label}
+
+Quic nodes that send data using IPv6 SHOULD document the IPv6 flow label
+in compliance with {{!RFC6437}}, unless the local API does not allow
+setting this parameter.
+
+The IPv6 flow label should be a pseudo-random function of the source
+and destination addresses, source and destination UDP ports, and the destination
+CID. The flow label generation MUST be designed to minimize the chances of
+collision with a previously used flow label, as this would enable linkability
+of multiple paths (see {{migration-linkability}}).
+
+A possible implementation is to compute the flow label as a one way
+hash function of the source and destination addresses, source and
+destination UDP ports, destination CID and a local secret.

```suggestion
destination UDP ports, destination CID, and a local secret.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2399#pullrequestreview-198899307