Re: [quicwg/base-drafts] Congestion window reduced on ACK (#2244)
ianswett <notifications@github.com> Fri, 21 December 2018 21:07 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BE06130F04 for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:07:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xbjUPX8_dd5q for <quic-issues@ietfa.amsl.com>; Fri, 21 Dec 2018 13:07:53 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id F21A6130EC0 for <quic-issues@ietf.org>; Fri, 21 Dec 2018 13:07:52 -0800 (PST)
Date: Fri, 21 Dec 2018 13:07:52 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1545426472; bh=i+5KwTON/s1eeix2hKBC16KmyCb80dZItcMEUlpD4Pw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LLQQfxYjPj0SwHHiVRS4Z7xePuIgtvJ3KnFbYe0Bc/6mRwSVehl+fTVUMe/kxhDp/ ygpchVZew6Vut0jiav7JsIHtLvZOzsFaXOQkmyZqJ3eYeLYp/NS4ueR+DtpLkd9awe AU+U4Iw51ANKmTi+GdTavzQlSrGxhMmLMV7X27+I=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab327b04db555981a6e549448f5a1fa2412f2342bb92cf000000011835182892a169ce177596a6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2244/review/187538518@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2244@github.com>
References: <quicwg/base-drafts/pull/2244@github.com>
Subject: Re: [quicwg/base-drafts] Congestion window reduced on ACK (#2244)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1d56283d1ed_3dc3fa8ac4d45c4559dc"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/YtrkZBCmYzIjioe5xKIN5tXhevk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2018 21:07:59 -0000
ianswett approved this pull request. Thanks for fixing this. Some editorial suggestions, but LG otherwise. > @@ -1023,15 +1027,13 @@ kLossReductionFactor: The RECOMMENDED value is 0.5. kPersistentCongestionThreshold: -: Number of consecutive PTOs after which network is considered to be +: Number of consecutive PTOs after which network might be considered to be ```suggestion : Number of consecutive PTOs after which the network is considered to be ``` I prefer "is" instead of "might be" given you already have considered. > experiencing persistent congestion. The rationale for this threshold is to - enable a sender to use initial PTOs for aggressive probing, similar to Tail - Loss Probe (TLP) in TCP {{TLP}} {{RACK}}. Once the number of consecutive PTOs - reaches this threshold - that is, persistent congestion is established - the - sender responds by collapsing its congestion window to kMinimumWindow, similar - to a Retransmission Timeout (RTO) in TCP {{RFC5681}}. The RECOMMENDED value - for kPersistentCongestionThreshold is 2, which is equivalent to having two - TLPs before an RTO in TCP. + enable a sender to use initial PTOs for aggressive probing, as TCP does with + Tail Loss Probe (TLP) {{TLP}} {{RACK}}, before establishing persistent + congestion, as TCP does with a Retransmission Timeout (RTO) {{?RFC5681}}. The + RECOMMENDED value for kPersistentCongestionThreshold is 2, which is equivalent + to having two TLPs before an RTO in TCP. ```suggestion to two TLPs before an RTO in TCP. ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2244#pullrequestreview-187538518
- [quicwg/base-drafts] Congestion window reduced on… janaiyengar
- Re: [quicwg/base-drafts] Congestion window reduce… janaiyengar
- Re: [quicwg/base-drafts] Congestion window reduce… ianswett
- Re: [quicwg/base-drafts] Congestion window reduce… janaiyengar
- Re: [quicwg/base-drafts] Congestion window reduce… janaiyengar
- Re: [quicwg/base-drafts] Congestion window reduce… ianswett
- Re: [quicwg/base-drafts] Congestion window reduce… ianswett
- Re: [quicwg/base-drafts] Congestion window reduce… janaiyengar
- Re: [quicwg/base-drafts] Congestion window reduce… janaiyengar