Re: [quicwg/base-drafts] Clarify handshake anti-deadlock wrt. handshake confirmation (#3503)

Martin Thomson <notifications@github.com> Sun, 08 March 2020 21:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B31EF3A0785 for <quic-issues@ietfa.amsl.com>; Sun, 8 Mar 2020 14:40:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.482
X-Spam-Level:
X-Spam-Status: No, score=-1.482 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KhnPjIAPjWTt for <quic-issues@ietfa.amsl.com>; Sun, 8 Mar 2020 14:40:55 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7D22A3A0784 for <quic-issues@ietf.org>; Sun, 8 Mar 2020 14:40:55 -0700 (PDT)
Received: from github-lowworker-45eca55.ac4-iad.github.net (github-lowworker-45eca55.ac4-iad.github.net [10.52.25.70]) by smtp.github.com (Postfix) with ESMTP id 41AA2660454 for <quic-issues@ietf.org>; Sun, 8 Mar 2020 14:40:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583703654; bh=jeDeh1QO3ey1QJs3QWsfB6I3Jg1Wx/ECkTh8LyS29QA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1k8nbj56OW3nrlLhutBimag0mWnZe4ogOh2cwlcyPbU9UffVu2eg1b97C5JXiI1P7 DfEFd7f5Zes0sSdBs6WuZ2K1d1JJ4Gr+R4ApLbjNaKGwQaA+YEZcIrrB/EepDK3GQY /Yulhxo5t2OdHOB0QyW8YuFP+7SZr9Kaicf/0k6M=
Date: Sun, 08 Mar 2020 14:40:54 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZQ34XLDEFVDGUSBM54OFDWNEVBNHHCE2EGHE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3503/review/370859969@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3503@github.com>
References: <quicwg/base-drafts/pull/3503@github.com>
Subject: Re: [quicwg/base-drafts] Clarify handshake anti-deadlock wrt. handshake confirmation (#3503)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e65666631260_74d23ff8bd0cd9602647fe"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z-KfBCicb1ccOP6c1tJqgyBS42o>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Mar 2020 21:40:57 -0000

martinthomson commented on this pull request.



> @@ -1162,7 +1162,7 @@ PeerNotAwaitingAddressValidation():
   # Servers complete address validation when a
   # protected packet is received.
   return has received Handshake ACK ||
-         has received 1-RTT ACK
+         has received 1-RTT ACK or a HANDSHAKE_DONE frame

```suggestion
       has received 1-RTT ACK ||
       has received HANDSHAKE_DONE
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3503#pullrequestreview-370859969