Re: [quicwg/base-drafts] Insert Count Increment instruction description has race condition (#3082)

afrind <notifications@github.com> Tue, 08 October 2019 15:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0976120026 for <quic-issues@ietfa.amsl.com>; Tue, 8 Oct 2019 08:23:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PE0fxzBcg1gR for <quic-issues@ietfa.amsl.com>; Tue, 8 Oct 2019 08:23:23 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19090120096 for <quic-issues@ietf.org>; Tue, 8 Oct 2019 08:23:23 -0700 (PDT)
Received: from github-lowworker-9bcb4a1.ac4-iad.github.net (github-lowworker-9bcb4a1.ac4-iad.github.net [10.52.25.84]) by smtp.github.com (Postfix) with ESMTP id 2722E2C130F for <quic-issues@ietf.org>; Tue, 8 Oct 2019 08:23:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1570548202; bh=ZsVaH048awLsvHWVAQpAifAwzngtPsaS/Nswcy5JNoo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=iTSGp5svTFIFYq8wDmLdeboL9V7pyvdrUcwNe6jKQGmcHeIs/hlx1THzwO4bfs5Fj zLkJ2viI6rVSwUDSvXuc6BdYB6PjvsraOf0kNtG/A53yX9LyRNOxNcvr4zkDo6SxtB jZI0RX0VaUcGTnpv962YnfvlB/JZ07QaV73lhVJU=
Date: Tue, 08 Oct 2019 08:23:22 -0700
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYM5FONDDRYDHCTJZN3VHVHVEVBNHHB4CZRUQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3082/539565925@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3082@github.com>
References: <quicwg/base-drafts/issues/3082@github.com>
Subject: Re: [quicwg/base-drafts] Insert Count Increment instruction description has race condition (#3082)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d9ca9ea189ff_7e043ff0504cd968125666"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z2840zDh5_P73Wc-HoUEWLtBF0g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Oct 2019 15:23:27 -0000

Ah, it needs to explicitly reference the Required Insert Count from the header block that was acked, rather than "since the last time".  I think this is editorial, since that's the intent of the text.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3082#issuecomment-539565925