Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Martin Thomson <notifications@github.com> Tue, 19 June 2018 06:39 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6A901130DC1 for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 23:39:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lK9ZNIG-kxJR for <quic-issues@ietfa.amsl.com>; Mon, 18 Jun 2018 23:39:25 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63CB012E039 for <quic-issues@ietf.org>; Mon, 18 Jun 2018 23:39:25 -0700 (PDT)
Date: Mon, 18 Jun 2018 23:39:24 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1529390364; bh=2mYmeMffXZD6+4cipmjDwOfaH3dHCYGwN30diW+FzzI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PW6z9BKb3Q1XA81iPqUZqOr8JCHeTuZMLMR74UcGtmMjvhrIFhiby8re9m4D9YGBi FIn72R/I1JGGKOcmvrhmgGQpLjYmwr6GHmJPFl7DcgS0I3i6FEqfcyItX7dIVrN5eD KACAIS2WILOoq2ots+ahsKRl5MWZY7VUOhOfKpdA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab337f6e5eabff51f503bb969750e22a4cdf190ba592cf000000011740671c92a169ce13656182@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1372/review/129833805@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1372@github.com>
References: <quicwg/base-drafts/pull/1372@github.com>
Subject: Re: [quicwg/base-drafts] Proposal for adding ECN support to QUIC. (#1372)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b28a51c5db9c_dabf3fc9650caf801310f1"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z5an48M_CUbJeterh8hNphDcnlk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2018 06:39:28 -0000
martinthomson commented on this pull request. > @@ -2887,6 +3033,95 @@ by a client in protected packets, because it is certain that the server is able to decipher the packet. +## ACK_ECN Frame {#frame-ack-ecn} + +A QUIC connection MUST keep counters for each ECN codepoint, recording +the number of packets that were received with the corresponding ECN +codepoint in the IP header. If the header is not readable from the +application, the codepoint 00 (Not-ECT) MUST be assumed. If any packet +are duplicated by the network then only the value of the ECN field of +the packet copy first received SHALL be included in the counters, the ECN +field value for a duplicate SHALL be ignored. This to prevent the The problem with that text is that it assumes something quite dangerous: that a receiver might accept a packet when it isn't sure that it has received it before. And content might be different. What @ianswett suggested before is better: if you move the trailing edge forward, then packets that you believe to be behind that edge are dropped unconditionally. Or, more concisely stated: you only accept packets that you know you haven't accepted before. That errs on the side of dropping rather than accepting, which I believe to be safe. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1372#discussion_r196308696
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … janaiyengar
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … janaiyengar
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … mirjak
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … ianswett
- [quicwg/base-drafts] Proposal for adding ECN supp… Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … IngJohEricsson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Martin Thomson
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Magnus Westerlund
- Re: [quicwg/base-drafts] Proposal for adding ECN … Kazuho Oku
- Re: [quicwg/base-drafts] Proposal for adding ECN … Lars Eggert