IETF Logo Mail Archive

Re: [quicwg/base-drafts] Split error code space (#722)

janaiyengar <notifications@github.com> Thu, 07 September 2017 23:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F3136133032 for <quic-issues@ietfa.amsl.com>; Thu, 7 Sep 2017 16:28:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.181
X-Spam-Level:
X-Spam-Status: No, score=-3.181 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0UQoohzKn0_4 for <quic-issues@ietfa.amsl.com>; Thu, 7 Sep 2017 16:28:49 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71C1F13302F for <quic-issues@ietf.org>; Thu, 7 Sep 2017 16:28:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=IPvCy58VgFRRlU1KeitMEbPTkqk=; b=hrwtydWuW9ErPL5D hcZ9SB9J1ibbFkh6C0zzrRs/P4m6zpI+b882vnrZ1/3wpDVu5WiX+4XDljUMJ5IY 3Khgx8zqHDJIHgwAh4ZuEUuAzV9gt4iNp9q76yBLdamydQO8McmA9dc/7Ifu/QB1 Cue5V+ctaVstW2uFA1Fx+Jkrml8=
Received: by filter0354p1las1.sendgrid.net with SMTP id filter0354p1las1-11798-59B1D630-A 2017-09-07 23:28:48.114692079 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0014p1las1.sendgrid.net (SG) with ESMTP id H-ahF9QBTGqg5IIx3LYMXw for <quic-issues@ietf.org>; Thu, 07 Sep 2017 23:28:47.989 +0000 (UTC)
Date: Thu, 07 Sep 2017 23:28:48 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab786a33d0b867ddf3965afbac45f50d2e2edb6e4692cf0000000115c9982f92a169ce0edfabce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/722/review/61379914@github.com>
In-Reply-To: <quicwg/base-drafts/pull/722@github.com>
References: <quicwg/base-drafts/pull/722@github.com>
Subject: Re: [quicwg/base-drafts] Split error code space (#722)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59b1d62f17ac9_1bcca3fc2b6fd3c30110210"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2taqg9+zno6JArLtJhKTBFbSswKABCNRGZ9g MaH5LoB5YolImAl+udEkxsgpONMaXFU9ncS0Sv8Q5edZFyNfM46MInowoVL1iGwtpLMRyyHzG8DAVh 5OUGYYNvfQ/WHEva3dC+YfpZVoCY2UOK+3RX8NHhG9L2dIGj812gy8gcW/t0zE6ONoe2JmDaXejyRx w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z68OKzpQiMVSKu-7gPhq6PN07s0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Sep 2017 23:28:51 -0000

janaiyengar commented on this pull request.

So, the only thing I have a concern about is that if the transport is required to send a RST_STREAM in response to a STOP_SENDING, what's it to send without an error code? I would remove that requirement. Of course, this puts the onus on the application, but I think that's a natural outcome. (I think it also clarifies that STOP_SENDING is really an application signal.)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/722#pullrequestreview-61379914

v2.46.0 | Report a Bug | By Email | System Status