Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)

Kazuho Oku <notifications@github.com> Tue, 22 October 2019 04:26 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0FA8D12004F for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:26:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.596
X-Spam-Level:
X-Spam-Status: No, score=-1.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lH7Exc11O2Bw for <quic-issues@ietfa.amsl.com>; Mon, 21 Oct 2019 21:26:13 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4C641120058 for <quic-issues@ietf.org>; Mon, 21 Oct 2019 21:26:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Cr0TTfnSzqV3HLmiUGOr2XU2XyY=; b=b4qeZMxLEqC4/h8R zhKc05H0iCdIfDm2q4jwPx+IWMbibdgo5E+9iZZby2UjSV3tKmEbiL7lb9jN0wJ3 0lZPgAq7bs5RBacmmHeVEJpvb2iLjfCBk1iVfKU5rHGipflRwEmmPiq4bj2Drxp9 +aPl2R0hOwurTXc6KgdF3TNL3x8=
Received: by filter0910p1las1.sendgrid.net with SMTP id filter0910p1las1-10809-5DAE7C75-38 2019-10-22 03:50:14.032206378 +0000 UTC m=+364464.847550992
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) by ismtpd0064p1iad2.sendgrid.net (SG) with ESMTP id T0gDXIpZTlSZZfAS2wn81g for <quic-issues@ietf.org>; Tue, 22 Oct 2019 03:50:13.743 +0000 (UTC)
Received: from github-lowworker-cde56e0.va3-iad.github.net (github-lowworker-cde56e0.va3-iad.github.net [10.48.25.52]) by smtp.github.com (Postfix) with ESMTP id 10602C6056C for <quic-issues@ietf.org>; Mon, 21 Oct 2019 20:50:08 -0700 (PDT)
Date: Tue, 22 Oct 2019 03:50:14 +0000 (UTC)
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZ5HYASMASNJFOKFHV3XOXO7EVBNHHB43A2P4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3128/review/304953073@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3128@github.com>
References: <quicwg/base-drafts/pull/3128@github.com>
Subject: Re: [quicwg/base-drafts] Mandatory distinction between token types (#3128)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dae7c6ff40b3_21b83ff051ecd96c14731c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0CCO/LpglgHHx8gLd16L1lnw2yX8Uu4dEcsP 2Sb703uipTI1Q9ADsXLk4jvfd3cECSxLE4hTMc2zhOum11c/IWy4wPfMEhfRWo+jmOaFanHUedvnv2 W7+24C1KDE6K1wnZwID4OD9UrUkgiV6vaxBVMgjmWHBxa3b0plry6xZAxgRgljwSiN/reP9pBjlatv k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Z6ysTUOZ9LG1wT3ab3pV-0CAF04>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Oct 2019 04:26:16 -0000

kazuho commented on this pull request.



> @@ -1623,6 +1623,20 @@ also constrained in what they can send by the limits set by the congestion
 controller.  Clients are only constrained by the congestion controller.
 
 
+### Token Construction
+
+Tokens sent in NEW_TOKEN frames or Retry packets MUST be constructed in a way
+that allows the server to identity how it was provided to a client.  These
+tokens are carried in the same field, but require different handling from
+servers.
+
+A token MUST NOT include information that would allow values to be linked by an

I think this requirement is specific to tokens used for validating future connections?

Therefore, something like "A token issued using NEW_TOKEN frames MUST NOT ..."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3128#pullrequestreview-304953073