Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)

Jana Iyengar <notifications@github.com> Thu, 14 May 2020 03:00 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA4033A093E for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 20:00:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.272
X-Spam-Level:
X-Spam-Status: No, score=-3.272 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AVsL-9ybo57E for <quic-issues@ietfa.amsl.com>; Wed, 13 May 2020 20:00:42 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A48023A093D for <quic-issues@ietf.org>; Wed, 13 May 2020 20:00:42 -0700 (PDT)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id CBA7E6611BD for <quic-issues@ietf.org>; Wed, 13 May 2020 20:00:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589425241; bh=oxOUEcuPcMlcCdc/GTv8Lqiw6DsWpHvN9FlnTWmVZ0k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wdCCpachDpGldOPpVHvTzqIBuV7b/wZb9sw+KXUL/i20uOJ6hVpxeijBk5vdqkZ3Z cXbVTeeWkGmE0K0A4AP+xqwi25UNYtx6c5929u5Z8GWmFla25KQzWzpiXXhjPIZ97V Fu41Gi9tzYJ7ROoHxCDNh64T05SNBHQuIq2MA6uA=
Date: Wed, 13 May 2020 20:00:41 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK767CCC6GSWUAXRDQV4ZCKVTEVBNHHCJTOADM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3653/review/411432230@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3653@github.com>
References: <quicwg/base-drafts/pull/3653@github.com>
Subject: Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebcb459bbb96_19093fc2c1acd960374563"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZAAfqSZLEgDk7780VIUtXg2szTU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 14 May 2020 03:00:46 -0000

@janaiyengar commented on this pull request.



> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Packet
+
+When a packet is received, it may allow the server to send
+if the server was previously amplification limited.
+
+Psuedocode for OnPacketReceived follows:
+
+~~~
+OnPacketReceived(packet):
+  // If this packet unblocks the server, arm the
+  // timer to ensure forward progress resumes
+  if (server was at anti-amplification limit):
+    SetLossDetectionTimer()
+  DecryptAndProcessFrames()

Yeah, I think this should be in the comments above.

> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Packet
+
+When a packet is received, it may allow the server to send
+if the server was previously amplification limited.
+
+Psuedocode for OnPacketReceived follows:
+
+~~~
+OnPacketReceived(packet):
+  // If this packet unblocks the server, arm the
+  // timer to ensure forward progress resumes

```suggestion
  // PTO timer to avoid deadlock.
```

> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Packet
+
+When a packet is received, it may allow the server to send
+if the server was previously amplification limited.
+
+Psuedocode for OnPacketReceived follows:
+
+~~~
+OnPacketReceived(packet):

+1. You don't need to process packets  in here, just say up above that this function is called even if the received packet is undecryptable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3653#pullrequestreview-411432230