IETF Logo Mail Archive

Re: [quicwg/base-drafts] Connection IDs for 0-RTT packets (#2450)

ianswett <notifications@github.com> Mon, 11 February 2019 14:38 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 43FCB129BBF for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 06:38:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KF_x9EnL04JT for <quic-issues@ietfa.amsl.com>; Mon, 11 Feb 2019 06:38:40 -0800 (PST)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EE76126F72 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 06:38:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=1AdwQaUzTFHEJq/IJwfSfLu+W84=; b=Fyg0/wmqb8DF9dcj Qz9v3syMPL2cf8EALcY58EQP4ld7SmoXsdXYRpkyxuX23HbrnjfMuQTev9RHWaRl tI8ycoRyk7fOWPIwjsooGlZMoozF5+Ulfmb5MbeEayUMgdvc/K7mtozRJ3l6Nju/ ve8ztWBREQjmEVUJLje8prOIPEY=
Received: by filter0995p1las1.sendgrid.net with SMTP id filter0995p1las1-2727-5C6188D6-2A 2019-02-11 14:38:14.527504236 +0000 UTC m=+236662.408905954
Received: from github-lowworker-1c220e1.cp1-iad.github.net (unknown [192.30.252.44]) by ismtpd0033p1iad2.sendgrid.net (SG) with ESMTP id TZBlSPSsQUuE0mZon-f6mg for <quic-issues@ietf.org>; Mon, 11 Feb 2019 14:38:14.427 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-1c220e1.cp1-iad.github.net (Postfix) with ESMTP id 64971160A41 for <quic-issues@ietf.org>; Mon, 11 Feb 2019 06:38:14 -0800 (PST)
Date: Mon, 11 Feb 2019 14:38:14 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1ef7dca9da9e7073b11321624a5d4d9e07bb29aa92cf0000000118794ad692a169ce185be425@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2450/review/202138080@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2450@github.com>
References: <quicwg/base-drafts/pull/2450@github.com>
Subject: Re: [quicwg/base-drafts] Connection IDs for 0-RTT packets (#2450)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c6188d66267f_6053fa8d3cd45b8152933"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1F75IQVdKNBsw5onhMM+Z2ppNajQZb22hgkQ 1O/Y8szanQcVUESF+GCX3MBEmFP4a7VGjMH7VISPjhcylwK3Ilf3ACB2L9e8CSH9tUPo8sOJwomQK+ KA/0vTEvKzF4EL0Z4RhbHh73nmmeNgsauRfOT10xbHWxqEEQHS5nvfpcYA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZI9Gjb2jKngyRergFagJR5wFzTM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Feb 2019 14:38:42 -0000

ianswett commented on this pull request.



> @@ -1355,6 +1355,9 @@ long enough to fulfill the minimum size for every QUIC version it supports.
 The client populates the Source Connection ID field with a value of its choosing
 and sets the SCIL field to match.
 
+The same Destination and Source Connection ID values are used for any 0-RTT
+packets the client sends.
+

Agreed, this is not completely clear.  How about: "The first flight of 0-RTT packets use the same Destination and Source Connection ID values as the client's first Initial."?

Also, on 1356, "sets the SCIL field to match." is not very clear.  I'd either drop the clause or say "and sets the SCIL field to indicate the length."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2450#discussion_r255533138

v2.23.0 | Report a Bug | By Email