IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make lint faster (#938)

Mike Bishop <notifications@github.com> Fri, 17 November 2017 01:01 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C91A126D0C for <quic-issues@ietfa.amsl.com>; Thu, 16 Nov 2017 17:01:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.615
X-Spam-Level:
X-Spam-Status: No, score=-0.615 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FfgIFn0_sWSY for <quic-issues@ietfa.amsl.com>; Thu, 16 Nov 2017 17:01:22 -0800 (PST)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A915F126CD8 for <quic-issues@ietf.org>; Thu, 16 Nov 2017 17:01:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=O/l2wCYOW1TOur0pUUUTSPw50wI=; b=xL9tYEEhY5DEo5qq OW0zrV1YfR1ob297Ll6NG72oHxKASbuzCswXsiN2NdeLkO05XXrh0G2HsWOC83nZ xVCaTSY5g3YNafR1jiY1FvcErr+bNFWtUoFmM1Qzmj2N7HxYLF7p1dYvIXjRQL5c wPRj0mhrSZXUerTvDQHTN3G4WrE=
Received: by filter0163p1iad2.sendgrid.net with SMTP id filter0163p1iad2-2076-5A0E34AF-25 2017-11-17 01:00:31.588190858 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id I3Yv9ol6RJW_sifcI4SAWg for <quic-issues@ietf.org>; Fri, 17 Nov 2017 01:00:31.415 +0000 (UTC)
Date: Fri, 17 Nov 2017 01:00:31 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab56697dd11d9ecaf30805bd1dee5eeb1eb3e108db92cf000000011625f6af92a169ce105bfce4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/938/c345112891@github.com>
In-Reply-To: <quicwg/base-drafts/pull/938@github.com>
References: <quicwg/base-drafts/pull/938@github.com>
Subject: Re: [quicwg/base-drafts] Make lint faster (#938)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a0e34af4c631_25e73ff89e470f28132086"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
tracking:
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3DFlWvsDkDxGl+UQGjOZ1wAv5p0TG/Mf5mXy eA5VH3UF9S43Y6QHH7x9iZ4+vrJrt6e3yg1UI0U9JXA2H8drliHSkCdBKEFaFepxaNAaBtLrYPEROS ZTQFmTyLKNIvjBQ/Jzkv68lAwkgYErIukj8Ih8jN/tK0n4X0LEipisFGpP8cANO+tO0Ada8eQC71M/ U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZK3J-kOUvF4WyXma2gf6S8dxJYM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Nov 2017 01:01:24 -0000

You're right, that's a better design.  Also, I can fold the branch migration into that -- check at lint time whether I can steal a lint file from another branch rather than actually running the lint commands.

I'll rearchitect that later.  We should also perhaps update the Circle config to cache .lintcache as well.  Does that mean I need to make the directory controllable by an env variable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/938#issuecomment-345112891

v2.39.1 | Report a Bug | By Email | System Status