Re: [quicwg/base-drafts] Clarify 'packet protection' -> 'packet number protection' (#1406)

Alessandro Ghedini <notifications@github.com> Fri, 01 June 2018 18:59 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5A66E126E64 for <quic-issues@ietfa.amsl.com>; Fri, 1 Jun 2018 11:59:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r6m24CV5QCIx for <quic-issues@ietfa.amsl.com>; Fri, 1 Jun 2018 11:59:50 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 71785126BF3 for <quic-issues@ietf.org>; Fri, 1 Jun 2018 11:59:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=tKRFiq2Y0vSbqIToroFg+mTuxMY=; b=tYw7QKD8y1BiUBti SndS0RFI0JWukQZtA0/gybcFWVEF+ZYZ8Exm51mZoMp6dBiF5vKvxwatOcqpQhWw G6eOEI95hP+lWa6Z3T0uUzWTNDKQMd1i5Rl1pNdTNB1KcSzkeQOEW5n8ZTzcWcmG QpMv/s89ZWows3wvlxXF2FZIj+k=
Received: by filter1545p1mdw1.sendgrid.net with SMTP id filter1545p1mdw1-6435-5B1197A5-11 2018-06-01 18:59:49.279724338 +0000 UTC
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id 1e04DDy6REmJmMPoTD-kug for <quic-issues@ietf.org>; Fri, 01 Jun 2018 18:59:49.229 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id 3525BAE0291 for <quic-issues@ietf.org>; Fri, 1 Jun 2018 11:59:49 -0700 (PDT)
Date: Fri, 01 Jun 2018 18:59:49 +0000
From: Alessandro Ghedini <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2339fa1fc14c1ad875f9ffc3e9d409de1b06bcd192cf00000001172959a592a169ce1395a9b5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1406/review/125282057@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1406@github.com>
References: <quicwg/base-drafts/pull/1406@github.com>
Subject: Re: [quicwg/base-drafts] Clarify 'packet protection' -> 'packet number protection' (#1406)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b1197a532e23_be72aba84d8cf5c54555"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ghedo
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2nI+KqfQ78fitAOFAHo/rTlUVbkIL6d/o4c0 fN+PJSHDu0J82X2j6JccJNlP9vTrkytH0/M1up9DuZHKt5ZN95kEDum2Jh3L4mIXbBZ/NBxdx5HjIe z7FUNdA/Byt0SFyShABnTyK9YRTN9B8m15PbKUefazcKYvmwG+oJg6DN8fOsrphUP0EK4o8Ysz+ubg Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZL9kNmm2xQQx1rqS8AoKVqmLAmM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2018 18:59:53 -0000

ghedo commented on this pull request.



> @@ -826,8 +826,8 @@ in Section 5.3 of {{!TLS13}}, the IV length is the larger of 8 or N_MIN (see
 Section 4 of {{!AEAD=RFC5116}}; all ciphersuites defined in {{!TLS13}} have
 N_MIN set to 12).
 
-The size of the packet protection key is determined by the packet protection
-algorithm, see {{pn-encrypt}}.
+The size of the packet number protection key is determined by the packet number
+protection algorithm, see {{pn-encrypt}}.

So, the way I read it, is that key *and IV* length (i.e. key_length and iv_length) is actually defined in the paragraph before, but nowhere it says how long is the packet number encryption key (i.e. pn_key_length) which is what confused me (also considering the "see {{pn-encrypt}}" which didn't make a whole lot of sense to me since packet number encryption wasn't mentioned at all in that sentence).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1406#discussion_r192487235