Date: Tue, 04 Dec 2018 15:41:23 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab7bbb43b9161a814ef23e0fe31b2ec0850447f01f92cf00000001181e622392a169ce17097d1f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2089/review/181324889@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2089@github.com>
References: <quicwg/base-drafts/pull/2089@github.com>
Subject: Re: [quicwg/base-drafts] Repeat tokens in all Initial packets (#2089)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c06a0236d5f3_53f23f8560cd45b83062bf";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZOISbE6lNCme2IT3Sr3T4M6ZkUU>

----==_mimepart_5c06a0236d5f3_53f23f8560cd45b83062bf
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -1548,9 +1548,9 @@ frame (see {{validate-future}}).
 
 Upon receiving the client's Initial packet, the server can request address
 validation by sending a Retry packet ({{packet-retry}}) containing a token. This
-token MUST be repeated by the client in all Initial packets it sends after it receives the
-Retry packet.  In response to receiving a token in an Initial packet, a server
-can either abort the connection or permit it to proceed.
+token MUST be repeated by the client in all Initial packets it sends after it
+receives the Retry packet.  In response to receiving a token in an Initial
+packet, a server can either abort the connection or permit it to proceed.
 

SG, changed from receiving to processing, because otherwise I think this sentence is not really correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955
----==_mimepart_5c06a0236d5f3_53f23f8560cd45b83062bf
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -1548,9 +1548,9 @@ frame (see {{validate-future}}).
 
 Upon receiving the client&#39;s Initial packet, the server can request address
 validation by sending a Retry packet ({{packet-retry}}) containing a token. This
-token MUST be repeated by the client in all Initial packets it sends after it receives the
-Retry packet.  In response to receiving a token in an Initial packet, a server
-can either abort the connection or permit it to proceed.
+token MUST be repeated by the client in all Initial packets it sends after it
+receives the Retry packet.  In response to receiving a token in an Initial
+packet, a server can either abort the connection or permit it to proceed.
 
</pre>
<p>SG, changed from receiving to processing, because otherwise I think this sentence is not really correct.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq4y2BB3XFAUV2WX4JYYZxBf9FxY8ks5u1pejgaJpZM4Y9GLX">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1Q0xaDd9JPkHqfA-iQKtf35nrfJks5u1pejgaJpZM4Y9GLX.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #2089"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955",
"url": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett commented on 2089",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/2089#discussion_r238715955"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 418669271\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5c06a0236d5f3_53f23f8560cd45b83062bf--