IETF Logo Mail Archive

Re: [quicwg/base-drafts] Make error codes smaller (#723)

janaiyengar <notifications@github.com> Wed, 06 September 2017 00:28 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AF91A1321A0 for <quic-issues@ietfa.amsl.com>; Tue, 5 Sep 2017 17:28:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.473
X-Spam-Level:
X-Spam-Status: No, score=-0.473 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i2rrA1Od7KiF for <quic-issues@ietfa.amsl.com>; Tue, 5 Sep 2017 17:28:58 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6D1E31321CB for <quic-issues@ietf.org>; Tue, 5 Sep 2017 17:28:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=/kvY2cesys01Ngrvgb0L6ktoego=; b=EwycUcuqpwmeXIRV cAY6B9VFRGUPoOz2DE5+4BacY2PJQLbldbQvAPpFW4vJC90Qy/DFrewpfAkRXute EVWsNR3+MYvZtOO7C0Gv5dHjseZOMIMrSt46vhlU+ehqyTfy1azDNDCGM8Z3YgsL pVhJRYlt//u4oyJOeSk1aQiV+EQ=
Received: by filter0086p1las1.sendgrid.net with SMTP id filter0086p1las1-31759-59AF4148-1C 2017-09-06 00:28:56.784752401 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id 6T0VXgIBRzeglYpOhXRLvw for <quic-issues@ietf.org>; Wed, 06 Sep 2017 00:28:56.700 +0000 (UTC)
Date: Wed, 06 Sep 2017 00:28:57 +0000
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab48d43510e1bc7d1e3af95f1871cb271d85fd282292cf0000000115c7034892a169ce0edfb333@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/723/review/60776885@github.com>
In-Reply-To: <quicwg/base-drafts/pull/723@github.com>
References: <quicwg/base-drafts/pull/723@github.com>
Subject: Re: [quicwg/base-drafts] Make error codes smaller (#723)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59af41488d0a0_1d243fef7227fc3059253"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0IAA5uI2wSPXrcOohBxmDmkXClssv3UtklnI /NlJzewlSWAR75Kd3UI4+TrxyTQsYtKk8FmBn4orbnRBGtfvB/mR7uEMYeOgmie74UDfwCjf01Lj7V ADJ/3cZe98Wj57hG1TKsv/pl4k/pWPEdDvyHR6K4gwQ2vZ1IcF9RCsDi9NWGn/jcTD3yEankD5Simh s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZQPWv1qMnWAX7cITJnbtnQin-C4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Sep 2017 00:29:00 -0000

janaiyengar approved this pull request.

LGTM -- this seems sane. 64K ought to be enough for anybody! (TM)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/723#pullrequestreview-60776885

v2.39.1 | Report a Bug | By Email | System Status