Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint structures (#3115)

Robin Marx <notifications@github.com> Tue, 29 October 2019 13:17 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 425CA12080C for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 06:17:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wrszuH7N-Q3F for <quic-issues@ietfa.amsl.com>; Tue, 29 Oct 2019 06:17:07 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BDB97120801 for <quic-issues@ietf.org>; Tue, 29 Oct 2019 06:17:07 -0700 (PDT)
Date: Tue, 29 Oct 2019 06:17:06 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572355026; bh=kJuMslyNx6nluZlBMaiGg664qeiTyOWFnSTqSokSaUU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=OlpYXSve8CKC3EqJmCxsNqzYyrrcOuGG/B714+wss6yxtcVJAL0I1se25lzLJDcJd OpngpWECIWaVXwbz4fMpQKHv0hAnd0k5pK5UkqLPNMihculWwUEBACRlyFQQpzVcIf MhFMq/DVS0mQ6H1pvp97AX+RdI2vXtHgre1snS3w=
From: Robin Marx <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5ZAXL5OPQVYOZKUK53YVXFFEVBNHHB4UPZEI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3115/547414052@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3115@github.com>
References: <quicwg/base-drafts/issues/3115@github.com>
Subject: Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint structures (#3115)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db83bd293e26_7d593fb4b40cd96c55336"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rmarx
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZVswW-s7Szs1-bKZqleVNMBvqNI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Oct 2019 13:17:09 -0000

> Yeah sorry I should have recognised you were providing a simple example not the whole shebang. I will point out that this format begins to resemble @rmarx qlog definition in TypeScript notation. If we really did want to change things, he'd probably be interested in aligning them if possible.

For what it's worth, @nharper's example would look a bit like this in TypeScript notation:

```
class StreamFrame implements Frame {
 stream_id:varint;
 offset?:varint;
 length?:varint;
 data:Array<byte> = new Array<byte>(length);
}

interface GenericFrame {
 frame_type:varint,
 frame:Frame
}

interface Packet {
 frames:Array<GenericFrame>
}
```

I've been using this in qlog mainly for convenience but am willing to move to another format down the line if qlog actually gets adopted and this type of flexible format is used in other QUIC drafts. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3115#issuecomment-547414052