Date: Tue, 29 Oct 2019 06:17:06 -0700
From: Robin Marx <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5ZAXL5OPQVYOZKUK53YVXFFEVBNHHB4UPZEI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3115/547414052@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3115@github.com>
References: <quicwg/base-drafts/issues/3115@github.com>
Subject: Re: [quicwg/base-drafts] Don't use bitmap frames to describe varint
 structures (#3115)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5db83bd293e26_7d593fb4b40cd96c55336";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZVswW-s7Szs1-bKZqleVNMBvqNI>


----==_mimepart_5db83bd293e26_7d593fb4b40cd96c55336
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

> Yeah sorry I should have recognised you were providing a simple example not the whole shebang. I will point out that this format begins to resemble @rmarx qlog definition in TypeScript notation. If we really did want to change things, he'd probably be interested in aligning them if possible.

For what it's worth, @nharper's example would look a bit like this in TypeScript notation:

```
class StreamFrame implements Frame {
 stream_id:varint;
 offset?:varint;
 length?:varint;
 data:Array<byte> = new Array<byte>(length);
}

interface GenericFrame {
 frame_type:varint,
 frame:Frame
}

interface Packet {
 frames:Array<GenericFrame>
}
```

I've been using this in qlog mainly for convenience but am willing to move to another format down the line if qlog actually gets adopted and this type of flexible format is used in other QUIC drafts. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3115#issuecomment-547414052
----==_mimepart_5db83bd293e26_7d593fb4b40cd96c55336
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<blockquote>
<p>Yeah sorry I should have recognised you were providing a simple example not the whole shebang. I will point out that this format begins to resemble <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=2240689" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/rmarx">@rmarx</a> qlog definition in TypeScript notation. If we really did want to change things, he'd probably be interested in aligning them if possible.</p>
</blockquote>
<p>For what it's worth, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=653608" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/nharper">@nharper</a>'s example would look a bit like this in TypeScript notation:</p>
<pre><code>class StreamFrame implements Frame {
 stream_id:varint;
 offset?:varint;
 length?:varint;
 data:Array&lt;byte&gt; = new Array&lt;byte&gt;(length);
}

interface GenericFrame {
 frame_type:varint,
 frame:Frame
}

interface Packet {
 frames:Array&lt;GenericFrame&gt;
}
</code></pre>
<p>I've been using this in qlog mainly for convenience but am willing to move to another format down the line if qlog actually gets adopted and this type of flexible format is used in other QUIC drafts.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications&amp;email_token=AFTOJK3BVFKDPFYFCLGFZDDQRAZVFA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQOAJA#issuecomment-547414052">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK7OFEMC45S2ZIAFWJLQRAZVFANCNFSM4JB6VQ2Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK7X7O3ZDCX4N7RUVF3QRAZVFA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQOAJA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications\u0026email_token=AFTOJK3BVFKDPFYFCLGFZDDQRAZVFA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQOAJA#issuecomment-547414052",
"url": "https://github.com/quicwg/base-drafts/issues/3115?email_source=notifications\u0026email_token=AFTOJK3BVFKDPFYFCLGFZDDQRAZVFA5CNFSM4JB6VQ22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECQOAJA#issuecomment-547414052",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5db83bd293e26_7d593fb4b40cd96c55336--