Re: [quicwg/base-drafts] Replace alarm with timer (#1559)

[janaiyengar <[e-mail]>]

janaiyengar commented on this pull request.



> @@ -111,8 +111,8 @@ of frames contained in a packet affect recovery and congestion control logic:
   to as "retransmittable" below.
 
 * Long header packets that contain CRYPTO frames are critical to the
-  performance of the QUIC handshake and use shorter timers for acknowledgement
-  and retransmission.
+  performance of the QUIC handshake and use shorter timeouts for

undo this change -- shorter timeouts not timers.

> @@ -295,18 +295,18 @@ smoothed RTT value as the resumed connection's initial RTT.
 If no previous RTT is available, or if the network changes, the initial RTT
 SHOULD be set to 100ms.
 
-When CRYPTO frames are sent, the sender SHOULD set an alarm for the handshake
-timeout period.  When the alarm fires, the sender MUST retransmit all
-unacknowledged CRYPTO data by calling RetransmitAllUnackedHandshakeData(). On
-each consecutive firing of the handshake alarm without receiving an
+When CRYPTO frames are sent, the sender SHOULD set a timer for the handshake
+timeout period.  Upon timeout, the sender MUST retransmit all unacknowledged
+CRYPTO data by calling RetransmitAllUnackedHandshakeData(). On each
+consecutive firing of the handshake timer without receiving an

s/firing/expiration/

> @@ -350,51 +350,51 @@ regardless of the number of packets outstanding.  TCP's TLP assumes if at least
 A PTO value of at least 1.5*SRTT ensures that the ACK is overdue.  The 1.5 is
 based on {{?TLP}}, but implementations MAY experiment with other constants.
 
-To reduce latency, it is RECOMMENDED that the sender set and allow the TLP alarm
-to fire twice before setting an RTO alarm. In other words, when the TLP alarm
+To reduce latency, it is RECOMMENDED that the sender set and allow the TLP timer
+to fire twice before setting an RTO timer. In other words, when the TLP timer
 fires the first time, a TLP packet is sent, and it is RECOMMENDED that the TLP

you should just do s/fires/expires/ through the doc

>  detection. The algorithm used in QUIC is based on the RTO algorithm for TCP
 {{?RFC5681}} and is additionally resilient to spurious RTO events {{?RFC5682}}.
 
-When the last TLP packet is sent, an alarm is scheduled for the RTO period. When
-this alarm fires, the sender sends two packets, to evoke acknowledgements from
-the receiver, and restarts the RTO alarm.
+When the last TLP packet is sent, a timer is scheduled for the RTO period. When

s/a timer is scheduled/a timer is set/

>        if (smoothed_rtt == 0):
-        alarm_duration = 2 * kInitialRtt
+        timer_duration = 2 * kInitialRtt

s/timer_duration/timeout/

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1559#pullrequestreview-137244994