IETF Logo Mail Archive

Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)

Mike Bishop <notifications@github.com> Wed, 11 May 2022 14:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 73274C19E84C for <quic-issues@ietfa.amsl.com>; Wed, 11 May 2022 07:27:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.26
X-Spam-Level:
X-Spam-Status: No, score=-7.26 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.575, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_KAM_HTML_FONT_INVALID=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3_W9C6xSFJkf for <quic-issues@ietfa.amsl.com>; Wed, 11 May 2022 07:27:30 -0700 (PDT)
Received: from smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 69763C20D6FF for <quic-issues@ietf.org>; Wed, 11 May 2022 07:26:47 -0700 (PDT)
Received: from github-lowworker-65e4a37.va3-iad.github.net (github-lowworker-65e4a37.va3-iad.github.net [10.48.119.82]) by smtp.github.com (Postfix) with ESMTP id 7A03F340F9D for <quic-issues@ietf.org>; Wed, 11 May 2022 07:26:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1652279206; bh=NIfwNgCGGZGCRe50EDIeyZHwzFvsGaxInioJf6RwxJs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZyySH9sy+j+QjeDDMeB2B4YlJTughGEAet7y5N6ftDk4p5EI2qaIXycrG30wgNfKQ cwDt+X2ZjoN7/lfHbgWqTu1vwGmediNsOKwp0J3hz6VD03ZhUEK9On9fX5k5TZTucS Cq8QZ0aCr6xMvmcFPBk9VAYgiszxyZ/UREQDx+zo=
Date: Wed, 11 May 2022 07:26:46 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK237P4DT2GX57AMPD6ARD5CNEVBNHHES2CVWA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4989/review/969470736@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4989@github.com>
References: <quicwg/base-drafts/pull/4989@github.com>
Subject: Re: [quicwg/base-drafts] Capitalization and Consistency (PR #4989)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_627bc7a66c17e_4817d408768e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ZkjxuaUMlRupONW0DrepF7X7mO0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.34
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2022 14:27:32 -0000

@MikeBishop commented on this pull request.



>  
 The value of Base MUST NOT be negative. Though the protocol might operate
-correctly with a negative base using post-base indexing, it is unnecessary and
-inefficient. An endpoint MUST treat a field block with an S bit of 1 as invalid
-if the value of Required Insert Count is less than or equal to the value of
-Delta Base.
+correctly with a negative Base using post-Base indexing, it is unnecessary and
+inefficient. An endpoint MUST treat a field block with a sign bit of 1 as

https://github.com/quicwg/base-drafts/pull/4989/commits/8f847d3f971e8e8a16396887fc5692d45b753957 shows what that change looks like, capitalizing Sign throughout.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4989#discussion_r870374594
You are receiving this because you are subscribed to this thread.

Message ID: <quicwg/base-drafts/pull/4989/review/969470736@github.com>

v2.23.0 | Report a Bug | By Email