Re: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)

Lucas Pardue <notifications@github.com> Mon, 01 July 2019 14:14 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FA981200D7 for <quic-issues@ietfa.amsl.com>; Mon, 1 Jul 2019 07:14:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id igXYPcdYUS_p for <quic-issues@ietfa.amsl.com>; Mon, 1 Jul 2019 07:14:05 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 27D9B1200D5 for <quic-issues@ietf.org>; Mon, 1 Jul 2019 07:14:05 -0700 (PDT)
Date: Mon, 01 Jul 2019 07:14:03 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1561990443; bh=ugzWedJly8do50LRSyGEilCRPbsByZEQ/Xb2bxiga44=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JKNGjNLDekNyNAE8HVfzx6RFgnFeVdZabzvUdiS+A7zcVy7NVtc0jC3BeLlJj8bzH iRKXBQTcA8tEoSpaVGFdMAwQeVSPNbNJs4SLimSTGUES2kbfZBklVa+rgqlv4SgfKk DGJXBmMorAv3DW+4VfUoXuNjLtulTZQgReLgHnVM=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2CYWXQECYBGVWRSAF3E5D2XEVBNHHBULDWIQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2662/c507282456@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2662@github.com>
References: <quicwg/base-drafts/pull/2662@github.com>
Subject: Re: [quicwg/base-drafts] Replace HTTP_MALFORMED_FRAME error code (#2662)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d1a152bcfa3c_1fbb3ff5656cd960230179"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Zqpv0emAhiQdr4AE4o0zvKSIigk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Jul 2019 14:14:08 -0000

> I think my preference goes to merging INVALID_PRIORITY with FRAME_ERROR. 
Thanks for the feedback. It's an easy change to make. I'll wait for some supporting or dissenting voices but otherwise will do this.

> Regarding rearranging the numbers, I wonder if it would be possible to split the error codes into two groups: connection-level error codes and stream-level ones. In contrary to HTTP/2, most of the HTTP/3 error code are either a connection-level error code or a stream-level error code, not both.

This resonates with my earlier analysis. Some of this was captured in https://github.com/quicwg/base-drafts/issues/2816. But I think what you are suggesting is a slightly different thing. Can you explain what splitting might look like and how it would help? I think it gets complicated because 1) we may have a proxy that is trying to translate errors between H2 and H3. 2) stream errors can be upgraded to connection errors



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2662#issuecomment-507282456