Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)
mirjak <notifications@github.com> Fri, 21 August 2020 13:02 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D672F3A09C4 for <quic-issues@ietfa.amsl.com>; Fri, 21 Aug 2020 06:02:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8XaAKfWVNEVs for <quic-issues@ietfa.amsl.com>; Fri, 21 Aug 2020 06:02:20 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2882A3A09E4 for <quic-issues@ietf.org>; Fri, 21 Aug 2020 06:02:20 -0700 (PDT)
Received: from github-lowworker-f045d1f.ac4-iad.github.net (github-lowworker-f045d1f.ac4-iad.github.net [10.52.19.54]) by smtp.github.com (Postfix) with ESMTP id 18F43340058 for <quic-issues@ietf.org>; Fri, 21 Aug 2020 06:02:19 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1598014939; bh=eo+2PxgCoLotcDHHUB58PS5k1Cqg5T02/dPIBN2nWtc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ULVF5I2HTODjvejVWSMhx9d+p86DHb15zNOKtQbZFMI00qrxRwoSD2+5m+nKGLe3b RISJJqvwixt3oNvR1GgYxb0aJiOWrCxfuOpmPC8HTH0RP6cdoq0GUFYmBKvVjAFQ5a V77/usWhGye7eJc4pO59E9RN1QY6XIe9IxRnkIyE=
Date: Fri, 21 Aug 2020 06:02:19 -0700
From: mirjak <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3MW5ZK6SFKGCXEHMF5JOTNXEVBNHHCQBGZIM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3978/review/472468022@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3978@github.com>
References: <quicwg/base-drafts/pull/3978@github.com>
Subject: Re: [quicwg/base-drafts] Add some MUSTs to congestion control (#3978)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3fc5db6c15_9b61964639a9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mirjak
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_1xaVQCLYH0QH2bhc1PEO0PfGPY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Aug 2020 13:02:29 -0000
@mirjak commented on this pull request. > @@ -767,20 +767,22 @@ While in slow start, QUIC increases the congestion window by the number of bytes acknowledged when each acknowledgment is processed, resulting in exponential growth of the congestion window. -QUIC exits slow start upon loss or upon increase in the ECN-CE counter. -When slow start is exited, the congestion window halves and the slow start -threshold is set to the new congestion window. QUIC re-enters slow start -any time the congestion window is less than the slow start threshold, -which only occurs after persistent congestion is declared. +QUIC MUST exit slow start and enter congestion avoidance upon loss or upon +increase in the ECN-CE counter. When slow start is exited, the congestion +window halves and the slow start threshold is set to the new congestion Also for TCP it was always possible to send new data because of the packet conservation principle as when you receive an ACK that doesn't ack new data you still know that at least one packet was received and you can reduce your bytes_in_flight by one packet. The thing that TCP does by reducing the cwnd gradually over the recovery RTT is that you don't have the effect you describe above where your don't send anything for half an RTT and then keep sending with exactly the same rate as previously for the second half on the RTT and overload the network again. This is a feature that should be conserved with QUIC as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3978#discussion_r474681893
- [quicwg/base-drafts] Add some MUSTs (#3978) ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Martin Thomson
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Martin Thomson
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Martin Thomson
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Martin Thomson
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Mike Bishop
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Praveen Balasubramanian
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… ianswett
- Re: [quicwg/base-drafts] Add some MUSTs to conges… mirjak
- Re: [quicwg/base-drafts] Add some MUSTs to conges… Jana Iyengar