IETF Logo Mail Archive

Re: [quicwg/base-drafts] Document TCP RTO vs QUIC PTO (#3441)

Martin Thomson <notifications@github.com> Wed, 04 March 2020 00:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DC6183A08B2 for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 16:02:06 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.685
X-Spam-Level:
X-Spam-Status: No, score=-1.685 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gafC_5h8GYH8 for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 16:02:01 -0800 (PST)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BB3E03A08AE for <quic-issues@ietf.org>; Tue, 3 Mar 2020 16:02:00 -0800 (PST)
Received: from github-lowworker-6349a71.ac4-iad.github.net (github-lowworker-6349a71.ac4-iad.github.net [10.52.18.20]) by smtp.github.com (Postfix) with ESMTP id 6588FE0E04 for <quic-issues@ietf.org>; Tue, 3 Mar 2020 16:01:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583280119; bh=HLRo1BEFvx/JYRRi0g0hBZNYit1U78um3NwBzytGOps=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jRXtimIqGuaLBiBlo2zhH9EXtMB6RIqvZD3kmC6CvnjSvmuedSnB41F6/JcVoZ3xP 1H296MgmYRKjf2cM51VwI+hxFnyq98MO75jB3tw0105KWGHN6Ro9EoJGDvJFH54wYX ZF54dT6l85KXNqdkxZ5gk2Fo/aLrieQDugIAsXAQ=
Date: Tue, 03 Mar 2020 16:01:59 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYBOGBCI5QPMIJ6RLV4NLIPPEVBNHHCC7S66M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3441/review/368413724@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3441@github.com>
References: <quicwg/base-drafts/pull/3441@github.com>
Subject: Re: [quicwg/base-drafts] Document TCP RTO vs QUIC PTO (#3441)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e5eeff754b89_29253fea904cd9601086ad"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_3r1g8HbWK9YBtDyvFRKP46l-j0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Mar 2020 00:02:07 -0000

martinthomson commented on this pull request.



> +window whenever the timer expires.  In practice, this is similar to TCP with
+F-RTO, but it does allow more packets to be sent when the congestion window was
+not fully utilized prior to the probe timeout expiring. Though this is slightly

```suggestion
window whenever the timer expires.  In comparison to TCP with F-RTO
{{!RFC5682}}, which corrects an unnecessary collapse of the congestion window,
this design aims to prevent the window from collapsing. Though this is slightly
```

Perhaps?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3441#pullrequestreview-368413724

v2.20.3 | Report a Bug | By Email