Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
MikkelFJ <notifications@github.com> Tue, 27 August 2019 07:01 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 91F90120FAB for <quic-issues@ietfa.amsl.com>; Tue, 27 Aug 2019 00:01:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.353
X-Spam-Level:
X-Spam-Status: No, score=-6.353 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bEFf51INZA3p for <quic-issues@ietfa.amsl.com>; Tue, 27 Aug 2019 00:01:05 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DB3EA1200D8 for <quic-issues@ietf.org>; Tue, 27 Aug 2019 00:01:04 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id CCF1CA00B2 for <quic-issues@ietf.org>; Tue, 27 Aug 2019 00:01:03 -0700 (PDT)
Date: Tue, 27 Aug 2019 00:01:03 -0700
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7O4F3ZGQT4YGBHII53OIK37EVBNHHBZYSIIE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2987/c525168184@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2987@github.com>
References: <quicwg/base-drafts/pull/2987@github.com>
Subject: Re: [quicwg/base-drafts] Replace remove() with setting to null (#2987)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d64d52fbeff7_78093fa55fccd9601165bd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_7nERZO2Qf8KmZqAVvqjMJWUw9M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Aug 2019 07:01:07 -0000
I suspect the issues are about operational behaviour more than formalism, and a null test is just a proposed solution. If so, I think remove and contains is a much better approach. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2987#issuecomment-525168184
- [quicwg/base-drafts] Replace remove() with settin… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Martin Thomson
- Re: [quicwg/base-drafts] Replace remove() with se… MikkelFJ
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett
- Re: [quicwg/base-drafts] Replace remove() with se… Jana Iyengar
- Re: [quicwg/base-drafts] Replace remove() with se… ianswett