Date: Sun, 11 Nov 2018 01:12:47 -0800
From: Alexandre Ferrieux <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab6d34f45bdcfc756f615b7ed01ed8f71fdbd7741392cf0000000117ffb48f92a169ce169db605@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1988/review/173690088@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1988@github.com>
References: <quicwg/base-drafts/pull/1988@github.com>
Subject: Re: [quicwg/base-drafts] Add spin bit to transport draft (#1988)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5be7f28ff2dc8_254d3f93462d45c4196066";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_APKi5Y5XQ_TccZ4ns5ML_eDa78>


----==_mimepart_5be7f28ff2dc8_254d3f93462d45c4196066
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ferrieux commented on this pull request.



>  Reserved:
 
-: The sixth, seventh, and eighth bits (0x7) of byte 0 are reserved for
+: The seventh and eighth bits (0x3) of byte 0 are reserved for

By un-reserving them you're shorting any hope for other measurement, like loss bits. DO you decide this kind of things single-handedly ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745
----==_mimepart_5be7f28ff2dc8_254d3f93462d45c4196066
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ferrieux</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt;  Reserved:
 
-: The sixth, seventh, and eighth bits (0x7) of byte 0 are reserved for
+: The seventh and eighth bits (0x3) of byte 0 are reserved for
</pre>
<p>By un-reserving them you're shorting any hope for other measurement, like loss bits. DO you decide this kind of things single-handedly ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq_PH9xWQD7gWuFEBH_acCY4z4Ttlks5ut-oPgaJpZM4YYC_-">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1nmDX-O4fl-xI6MLqmzrTIfezWxks5ut-oPgaJpZM4YYC_-.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ferrieux commented on #1988"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745",
"url": "https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ferrieux commented on 1988",
"sections": [
{
"text": "",
"activityTitle": "**Alexandre Ferrieux**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ferrieux",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1988#discussion_r232479745"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 408956926\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5be7f28ff2dc8_254d3f93462d45c4196066--