Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)

ianswett <> Wed, 12 September 2018 17:00 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 114A9130E91 for <>; Wed, 12 Sep 2018 10:00:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id rYdDfHqCSqWe for <>; Wed, 12 Sep 2018 10:00:36 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by (Postfix) with ESMTPS id C1C05130E87 for <>; Wed, 12 Sep 2018 10:00:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed;; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=E2QSm7eE/PoFn7TDlPwprkqqShE=; b=nIQeLRVNZEsylntg iBPT+7rvU//GaJPdNYcZu1K+qngsVuVDxGctNIuMCbLOTA/ya0gZuud/1uzR5MpO w0k7UUoMB8PYO0TQxYS6zXarLnVzlPQQYnpNdEWD2Llz62oEF01k6D4gJCoa9QOR 4pZhfaW31nuPqaQa8GD5ivpDhAk=
Received: by with SMTP id filter0005p1iad2-8214-5B994631-2A 2018-09-12 17:00:33.72122158 +0000 UTC m=+498897.278283140
Received: from (unknown []) by (SG) with ESMTP id 9dSN7i2sRz64NQKiwXSKQQ for <>; Wed, 12 Sep 2018 17:00:33.678 +0000 (UTC)
Received: from (localhost []) by (Postfix) with ESMTP id B4C2C4C0285 for <>; Wed, 12 Sep 2018 10:00:33 -0700 (PDT)
Date: Wed, 12 Sep 2018 17:00:33 +0000
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/1715/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b994631ac042_1cc53f81e56d45c4456b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1NHE7iM6DM74zy03MuWU53pu9iS/9K2ZTCq0 hY4vVH31qZnyw+niDm546C02X1w00PJTCByCiwUlbeNI6rrkdkFWUNV2PRgp3HTSTgXGYXtLzKEwAs JNV36OwiOzPPghHHQrXdrQO/hEntvRZeEC8R1AA6cd+nhW8U1Hi6eS5l5g==
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 12 Sep 2018 17:00:38 -0000

ianswett commented on this pull request.

> @@ -1671,6 +1672,13 @@ disable_migration (0x0009):
   address other than that used to perform the handshake.  This parameter is a
   zero-length value.
+max_bytes_before_ack (0x000c):
+: An unsigned 32-bit integer that indicates the maximum number of bytes received
+  before an ACK frame should be sent. The peer sending this value indicates
+  to the receiver the value it should use.  If this value is absent, the
+  receiver may use any conformant acknowledgement algorithm.

Congestion control is byte-based, not packet based, hence the choice.  But I can see the packet vs byte based going either way.

In order to use max_ack_delay effectively, I think it's almost necessary to be able to update it during the connection.  Fraction of an RTT may not need to be updated during a connection, admittedly.  max_ack_delay also feeds into TLP and RTO timers, so making it fraction of an RTT could be a bit dangerous if one side has a poor estimate of RTT.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: