Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)

ianswett <notifications@github.com> Wed, 12 September 2018 17:00 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 114A9130E91 for <quic-issues@ietfa.amsl.com>; Wed, 12 Sep 2018 10:00:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rYdDfHqCSqWe for <quic-issues@ietfa.amsl.com>; Wed, 12 Sep 2018 10:00:36 -0700 (PDT)
Received: from o9.sgmail.github.com (o9.sgmail.github.com [167.89.101.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C1C05130E87 for <quic-issues@ietf.org>; Wed, 12 Sep 2018 10:00:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=E2QSm7eE/PoFn7TDlPwprkqqShE=; b=nIQeLRVNZEsylntg iBPT+7rvU//GaJPdNYcZu1K+qngsVuVDxGctNIuMCbLOTA/ya0gZuud/1uzR5MpO w0k7UUoMB8PYO0TQxYS6zXarLnVzlPQQYnpNdEWD2Llz62oEF01k6D4gJCoa9QOR 4pZhfaW31nuPqaQa8GD5ivpDhAk=
Received: by filter0005p1iad2.sendgrid.net with SMTP id filter0005p1iad2-8214-5B994631-2A 2018-09-12 17:00:33.72122158 +0000 UTC m=+498897.278283140
Received: from github-lowworker-c7d2ff2.cp1-iad.github.net (unknown [192.30.252.32]) by ismtpd0021p1iad2.sendgrid.net (SG) with ESMTP id 9dSN7i2sRz64NQKiwXSKQQ for <quic-issues@ietf.org>; Wed, 12 Sep 2018 17:00:33.678 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-c7d2ff2.cp1-iad.github.net (Postfix) with ESMTP id B4C2C4C0285 for <quic-issues@ietf.org>; Wed, 12 Sep 2018 10:00:33 -0700 (PDT)
Date: Wed, 12 Sep 2018 17:00:33 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe8d5335c5a00a695282a634618d9256f73985ad992cf0000000117b1083192a169ce152ea636@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1715/review/154749659@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1715@github.com>
References: <quicwg/base-drafts/pull/1715@github.com>
Subject: Re: [quicwg/base-drafts] Add max_bytes_before_ack to transport (#1715)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b994631ac042_1cc53f81e56d45c4456b3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1NHE7iM6DM74zy03MuWU53pu9iS/9K2ZTCq0 hY4vVH31qZnyw+niDm546C02X1w00PJTCByCiwUlbeNI6rrkdkFWUNV2PRgp3HTSTgXGYXtLzKEwAs JNV36OwiOzPPghHHQrXdrQO/hEntvRZeEC8R1AA6cd+nhW8U1Hi6eS5l5g==
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_AXpbKU2oDNKVk_rR6Mj0mHN_2k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Sep 2018 17:00:38 -0000

ianswett commented on this pull request.



> @@ -1671,6 +1672,13 @@ disable_migration (0x0009):
   address other than that used to perform the handshake.  This parameter is a
   zero-length value.
 
+max_bytes_before_ack (0x000c):
+
+: An unsigned 32-bit integer that indicates the maximum number of bytes received
+  before an ACK frame should be sent. The peer sending this value indicates
+  to the receiver the value it should use.  If this value is absent, the
+  receiver may use any conformant acknowledgement algorithm.
+

Congestion control is byte-based, not packet based, hence the choice.  But I can see the packet vs byte based going either way.

In order to use max_ack_delay effectively, I think it's almost necessary to be able to update it during the connection.  Fraction of an RTT may not need to be updated during a connection, admittedly.  max_ack_delay also feeds into TLP and RTO timers, so making it fraction of an RTT could be a bit dangerous if one side has a poor estimate of RTT.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1715#discussion_r217112524