Date: Tue, 31 Mar 2020 09:21:05 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK3NQRYP7QL2VGPPJXF4R5HPDEVBNHHCF2VMJI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3540/c606730634@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3540@github.com>
References: <quicwg/base-drafts/pull/3540@github.com>
Subject: Re: [quicwg/base-drafts] Notify the congestion controller of losses
 first (#3540)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e836df1adc5b_7ec93f8ac06cd95c1280d9";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_BbYMqVA3FiGQKNBPZ8xDvUqXVg>


----==_mimepart_5e836df1adc5b_7ec93f8ac06cd95c1280d9
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@marten-seemann my reasoning was I thought it was critical to determine what packets were newly acked before invoking loss detection.  In some cases it may be(depending upon details of one's loss detection), but since we update largest_acked_packet[pn_space] outside the code which detects newly acked packets, it's not critical to the pseudocode as it stands today.

That being said, I think the parallelism is nice, so I'd prefer to keep it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3540#issuecomment-606730634
----==_mimepart_5e836df1adc5b_7ec93f8ac06cd95c1280d9
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/marten-seemann/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/marten-seemann">@marten-seemann</a> my reasoning was I thought it was critical to determine what packets were newly acked before invoking loss detection.  In some cases it may be(depending upon details of one's loss detection), but since we update largest_acked_packet[pn_space] outside the code which detects newly acked packets, it's not critical to the pseudocode as it stands today.</p>
<p>That being said, I think the parallelism is nice, so I'd prefer to keep it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3540#issuecomment-606730634">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK62B6SHXZM4D5WYCBTRKIJ7DANCNFSM4LRNSNXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJKZ4TFHGWZLAFBFGWTDRKIJ7DA5CNFSM4LRNSNX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQU7TCQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3540#issuecomment-606730634",
"url": "https://github.com/quicwg/base-drafts/pull/3540#issuecomment-606730634",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e836df1adc5b_7ec93f8ac06cd95c1280d9--