IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)

Mike Bishop <notifications@github.com> Fri, 17 January 2020 04:59 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E78A81200CD for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 20:59:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.382
X-Spam-Level:
X-Spam-Status: No, score=-1.382 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id us66PVxrxPhR for <quic-issues@ietfa.amsl.com>; Thu, 16 Jan 2020 20:59:21 -0800 (PST)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9ACE0120099 for <quic-issues@ietf.org>; Thu, 16 Jan 2020 20:59:21 -0800 (PST)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id B1146E009A for <quic-issues@ietf.org>; Thu, 16 Jan 2020 20:59:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579237160; bh=2KJlN7D5TH0QJfKLH3LYdkUpT84QpigB4xS2nRTw+WQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tsugZgd09Lf1iEp7V/DQBqgAP3dUxgZtzrs8G11fzdIbxtY15hfp3ToMEq3AL2u2N WVQCqHfznqZlN/o8XiaUrDsQWCSBH9i0T0fsM9BvFf1tYLSga7kpkmyrNQyI6hJIqu dDadgJO/lUavQ0iZ3eoO/4D7vK4x+xNaH7k1QH2I=
Date: Thu, 16 Jan 2020 20:59:20 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZYWZRLPO6TDY4A4M54FZY2REVBNHHCBV7VNU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3352/review/344364210@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3352@github.com>
References: <quicwg/base-drafts/pull/3352@github.com>
Subject: Re: [quicwg/base-drafts] Clarify and split the "malformed" definition (#3352)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e213f28a2070_372b3fd8afacd95c941f8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_S5Q0HgSDhSaOj8u2G4HrG0dq3Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jan 2020 04:59:23 -0000

MikeBishop commented on this pull request.



> @@ -410,10 +417,10 @@ considered invalid.
 
 An HTTP request/response exchange fully consumes a bidirectional QUIC stream.

Good call.  Yes, this covers pushes, too -- it's a response message that follows this format.  (I don't see *why* you'd push with a non-final response in the sequence, but it's totally valid....)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3352#discussion_r367769603

v2.23.0 | Report a Bug | By Email