IETF Logo Mail Archive

Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)

Martin Thomson <notifications@github.com> Tue, 25 September 2018 17:13 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6046212426A for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 10:13:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.999
X-Spam-Level:
X-Spam-Status: No, score=-2.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vq9FigbGUnpY for <quic-issues@ietfa.amsl.com>; Tue, 25 Sep 2018 10:13:50 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3A6C7124D68 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 10:13:50 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=XD0REZaUN0UfX0s0Yxu4HvcWeJg=; b=Kmxd2uFo/20w792M 2FlQNpm+9g00zHi7gJ+n2b0NGBXG0PdQpA2Bbp+h+RTdIrkCTjzUcN3KCSLeui69 cwzyBnr6nEPLDokorHJz/C9qZx08YcJx2Cl83TYwndUdYtBTcitUpd61cImcb69l u0x99neb8BwE6UPJ1g+bV+S2aeA=
Received: by filter0343p1iad2.sendgrid.net with SMTP id filter0343p1iad2-20647-5BAA6CCC-22 2018-09-25 17:13:48.684289548 +0000 UTC m=+7589.858355173
Received: from github-lowworker-e55e3e3.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0015p1iad2.sendgrid.net (SG) with ESMTP id 73JbOR0vRVetEgTJVbJbkQ for <quic-issues@ietf.org>; Tue, 25 Sep 2018 17:13:48.714 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e55e3e3.cp1-iad.github.net (Postfix) with ESMTP id A6BF6180059 for <quic-issues@ietf.org>; Tue, 25 Sep 2018 10:13:48 -0700 (PDT)
Date: Tue, 25 Sep 2018 17:13:48 +0000
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abaf015cb495f786ff63ab96c4d3931801842ed32292cf0000000117c22ecc92a169ce14620d9d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1575/424424893@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1575@github.com>
References: <quicwg/base-drafts/issues/1575@github.com>
Subject: Re: [quicwg/base-drafts] Consider simplifying Packet Number Encryption (#1575)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5baa6ccca54fa_56b93fa76d2d45c0541e6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak0YjD3b2qFBaFhS3rxVmnn7A1NwaX7/TCSeAZ 1CvUwYbC7RW4Jsed6KFcDlgzreLr4cyZJzFFgIJmgxEefBbk5o+ZgEc4JOZ0fgtubTe9hOeaJW/ijy FkEElJ/4p/qht0zhxMfxkqoBkyGBuvU8inTJwPGDAx9Co9rIAeiScDnvUcA8kbV9tqCsOjG/QD88Uk s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_bpo7MUhx_allSBCQBrPtdV9TKs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 17:13:52 -0000

That sounds good.  We can stipulate that a packet MUST always contain at least 3 octets of frames.  Adding a couple of padding octets is probably a good idea.

Note that we're probably changing the encoding of packet numbers (again, yeah, sorry), so the precise set of 

Not sure whether you mean that you always XOR 4 octets (which means XOR over the encrypted payload if the packet number is <4), or whether you only XOR the octets of the packet number.  With the proposed move of the packet number length to the first octet, it's probably better to only XOR the octets of the packet number.  That way you don't touch the payload octets other than to sample them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1575#issuecomment-424424893

v2.23.0 | Report a Bug | By Email