Date: Tue, 25 Sep 2018 17:13:48 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abaf015cb495f786ff63ab96c4d3931801842ed32292cf0000000117c22ecc92a169ce14620d9d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1575/424424893@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1575@github.com>
References: <quicwg/base-drafts/issues/1575@github.com>
Subject: Re: [quicwg/base-drafts] Consider simplifying Packet Number
 Encryption (#1575)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5baa6ccca54fa_56b93fa76d2d45c0541e6";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_bpo7MUhx_allSBCQBrPtdV9TKs>

----==_mimepart_5baa6ccca54fa_56b93fa76d2d45c0541e6
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

That sounds good.  We can stipulate that a packet MUST always contain at least 3 octets of frames.  Adding a couple of padding octets is probably a good idea.

Note that we're probably changing the encoding of packet numbers (again, yeah, sorry), so the precise set of 

Not sure whether you mean that you always XOR 4 octets (which means XOR over the encrypted payload if the packet number is <4), or whether you only XOR the octets of the packet number.  With the proposed move of the packet number length to the first octet, it's probably better to only XOR the octets of the packet number.  That way you don't touch the payload octets other than to sample them.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1575#issuecomment-424424893
----==_mimepart_5baa6ccca54fa_56b93fa76d2d45c0541e6
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p>That sounds good.  We can stipulate that a packet MUST always contain at=
 least 3 octets of frames.  Adding a couple of padding octets is probably a=
 good idea.</p>
<p>Note that we're probably changing the encoding of packet numbers (again,=
 yeah, sorry), so the precise set of</p>
<p>Not sure whether you mean that you always XOR 4 octets (which means XOR =
over the encrypted payload if the packet number is &lt;4), or whether you o=
nly XOR the octets of the packet number.  With the proposed move of the pac=
ket number length to the first octet, it's probably better to only XOR the =
octets of the packet number.  That way you don't touch the payload octets o=
ther than to sample them.</p>

<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&mda=
sh;<br />You are receiving this because you are subscribed to this thread.<=
br />Reply to this email directly, <a href=3D"https://github.com/quicwg/bas=
e-drafts/issues/1575#issuecomment-424424893">view it on GitHub</a>, or <a h=
ref=3D"https://github.com/notifications/unsubscribe-auth/AWbkqxorKCg8dgC8Az=
jXVhEVR8R4P4cZks5uemRMgaJpZM4VTEWJ">mute the thread</a>.<img src=3D"https:/=
/github.com/notifications/beacon/AWbkqxRlQnIVdt1KFGwgqxihCYNWLucIks5uemRMga=
JpZM4VTEWJ.gif" height=3D"1" width=3D"1" alt=3D"" /></p>
<script type=3D"application/json" data-scope=3D"inboxmarkup">{"api_version"=
:"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"Gi=
tHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg=
/base-drafts","subtitle":"GitHub repository","main_image_url":"https://asse=
ts-cdn.github.com/images/email/message_cards/header.png","avatar_image_url"=
:"https://assets-cdn.github.com/images/email/message_cards/avatar.png","act=
ion":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"=
}},"updates":{"snippets":[{"icon":"PERSON","message":"@martinthomson in #15=
75: That sounds good.  We can stipulate that a packet MUST always contain a=
t least 3 octets of frames.  Adding a couple of padding octets is probably =
a good idea.\r\n\r\nNote that we're probably changing the encoding of packe=
t numbers (again, yeah, sorry), so the precise set of \r\n\r\nNot sure whet=
her you mean that you always XOR 4 octets (which means XOR over the encrypt=
ed payload if the packet number is \u003c4), or whether you only XOR the oc=
tets of the packet number.  With the proposed move of the packet number len=
gth to the first octet, it's probably better to only XOR the octets of the =
packet number.  That way you don't touch the payload octets other than to s=
ample them."}],"action":{"name":"View Issue","url":"https://github.com/quic=
wg/base-drafts/issues/1575#issuecomment-424424893"}}}</script>
<script type=3D"application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/1575#issuecomment-4=
24424893",
"url": "https://github.com/quicwg/base-drafts/issues/1575#issuecomment-4244=
24893",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [quicwg/base-drafts] Consider simplifying Packet Number Encry=
ption (#1575)",
"sections": [
{
"text": "",
"activityTitle": "**Martin Thomson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/=
avatar.png",
"activitySubtitle": "@martinthomson",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"q=
uicwg/base-drafts\",\n\"issueId\": 1575,\n\"IssueComment\": \"{{IssueCommen=
t.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"qui=
cwg/base-drafts\",\n\"issueId\": 1575\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/issues/1575#issuecomment-4244=
24893"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 357320073=
\n}"
}
],
"themeColor": "26292E"
}
]</script>=

----==_mimepart_5baa6ccca54fa_56b93fa76d2d45c0541e6--