Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)

MikkelFJ <> Mon, 04 November 2019 21:45 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 961AE120885 for <>; Mon, 4 Nov 2019 13:45:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id ftdRn9ghDfWR for <>; Mon, 4 Nov 2019 13:45:08 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 0172F120949 for <>; Mon, 4 Nov 2019 13:45:07 -0800 (PST)
Received: from ( []) by (Postfix) with ESMTP id 2CDBF6619D1 for <>; Mon, 4 Nov 2019 13:45:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1572903907; bh=injZ0rwGRl9OK3M3NHy7FG6/mY+yeA42OXAwDuVqcLc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oOVn9bah5msm+RgrYERNuYmWKx4sHPtIm6p061+PD7/pzqm84GuPZF4b3uVOlMQnq nUyVudKIA6GAGYV5JYxTueHgBY0edP9zNsgQpB5I7rtmOokQRtEtyhsG6iJpzQ9Ffa 59X1jjwGA857VTmLCl1ab0XrHPKJESLnzTUAcmuY=
Date: Mon, 04 Nov 2019 13:45:07 -0800
From: MikkelFJ <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3186/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] allow CRYPTO_BUFFER_EXCEEDED when overflowing a CRYPTO frame (#3186)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc09be31e7a3_31e03fa7856cd95c6599ca"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 04 Nov 2019 21:45:18 -0000

I can see how this can simplify some decoding logic, but I am not sure we should consider such a value valid in the first place. If the value is invalid it is meaningless to discuss length and then there is only a frame error left. Otherwise we could probably revisit a gazillion other places where this principle could also apply.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: