Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
ekr <notifications@github.com> Mon, 19 March 2018 12:32 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BB83712785F for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 05:32:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.008
X-Spam-Level:
X-Spam-Status: No, score=-7.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UR7MRvlFT0Uc for <quic-issues@ietfa.amsl.com>; Mon, 19 Mar 2018 05:32:31 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2BFB01242F5 for <quic-issues@ietf.org>; Mon, 19 Mar 2018 05:32:31 -0700 (PDT)
Date: Mon, 19 Mar 2018 05:32:30 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1521462750; bh=/n4XRASPz8j2+j/d2ydeIF3zEr5dczI3xRCWBCsjLJU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yKJQyJ+Jbd0gPgbYLY9Dagm7q7tUczLC0TsQDB1NHE3GZnIH847/5Kba7n+pkpdDP okcghOFR+xa+nkTxZ6EeWcYzWxdL3Lj2ZlPNmnccvpEU95f0W1ryLugn6NMStOkIVQ UfkcPOtMahK0Lg2e+p0i2XDRVJCN++HPqIoyjlcU=
From: ekr <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6c3fa88b7ebd326253042bbfc7f4ccc7ee5b051992cf0000000116c76fde92a169ce12418d6a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1231/review/104941468@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1231@github.com>
References: <quicwg/base-drafts/pull/1231@github.com>
Subject: Re: [quicwg/base-drafts] Restrict ACK-clocking to ACK-only frames. (#1231)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aafadde2eb08_64f33fe79b44ef2c356273"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ekr
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_uFcc72RspBxy5FartAZeCKgZEY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Mar 2018 12:32:33 -0000
ekr commented on this pull request. > To limit ACK blocks to those that have not yet been received by the sender, the receiver SHOULD track which ACK frames have been acknowledged by its peer. Once an ACK frame has been acknowledged, the packets it acknowledges SHOULD NOT be acknowledged again. -A receiver that is only sending ACK frames will not receive acknowledgments for -its packets. Sending an occasional MAX_DATA or MAX_STREAM_DATA frame as data is -received will ensure that acknowledgements are generated by a peer. Otherwise, -an endpoint MAY send a PING frame once per RTT to solicit an acknowledgment. +Because ACK-only packets are not acknowledged, a receiver that is only +sending ACK frames will only receive acknowledgements for its packets +if the sender piggybacks them on other packets. In order to enable That part of the text is correct. What's not correct is the claim that you will not receive ACKs if you do not do so. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1231#discussion_r175418177
- [quicwg/base-drafts] Restrict ACK-clocking to ACK… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… MikkelFJ
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… MikkelFJ
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Marten Seemann
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ekr
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… ianswett
- Re: [quicwg/base-drafts] Restrict ACK-clocking to… Martin Thomson