Re: [quicwg/base-drafts] Why is ipAddress variable length (#2158)

Kazuho Oku <notifications@github.com> Fri, 14 December 2018 01:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 42D04130EF7 for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 17:12:50 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZtsqsWXGj_cD for <quic-issues@ietfa.amsl.com>; Thu, 13 Dec 2018 17:12:49 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D56CF130ED9 for <quic-issues@ietf.org>; Thu, 13 Dec 2018 17:12:48 -0800 (PST)
Date: Thu, 13 Dec 2018 17:12:47 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1544749967; bh=97WvdNikDdyRWMop47/5yzleDIvTdlQXnsbybtZAV8w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=aMi8cRhpnPfPQlRBP+gfkSZCYcWGQYMTnvCD2FwNA4nM7Fc3RD/yDxV6syuwdshvx s2AH8RaNVc19/juAqgTN8DVS5nOYtyMi1MWxxyZbDmSOvsTAEepJndPrL7OwBLoxFJ ncxbPbqPPJ5+qkE48EJyY6RtCkvpwQi50A9rkNZE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab77009a981b5c8788c70e1b29be4c15594e3d84bb92cf00000001182ac58f92a169ce174c0707@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2158/447178623@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2158@github.com>
References: <quicwg/base-drafts/issues/2158@github.com>
Subject: Re: [quicwg/base-drafts] Why is ipAddress variable length (#2158)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c13038fb38b3_1c933fc3950d45c467545"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/_vvNO2ouSjSAqFZ4eAp2OkzaMXY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2018 01:12:50 -0000

@ekr 
> Unfortunately, it does not, because the version I proposed would include the size of the port in the length.

I see. So your version is equivalent to:
```
struct IPv4Address {
    byte ipaddr[4];
    uint16 port;
};

struct IPv6Address {
    byte ipaddr[16];
    uint16 port;
};

struct Address {
    enum { ... } ipVersion;
    struct {
        switch (ipVersion) {
        case v4: IPv4Address;
        case v6: IPv6Address;
       }
    } <0..2^8-1>;
};
```

That works for me, and I think it makes sense to define `port` as a property of each address type.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2158#issuecomment-447178623