From nobody Tue Sep 22 18:37:17 2020
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id D647C3A097D
 for <quic-issues@ietfa.amsl.com>; Tue, 22 Sep 2020 18:37:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.703
X-Spam-Level: 
X-Spam-Status: No, score=-3.703 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.695, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id TWmRSFm0VH_E for <quic-issues@ietfa.amsl.com>;
 Tue, 22 Sep 2020 18:37:14 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203])
 (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id B5C043A0824
 for <quic-issues@ietf.org>; Tue, 22 Sep 2020 18:37:14 -0700 (PDT)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net
 (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66])
 by smtp.github.com (Postfix) with ESMTP id 9876EE1E3B
 for <quic-issues@ietf.org>; Tue, 22 Sep 2020 18:37:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1600825033;
 bh=d6um0DXGfgKlYTuwFsBslNiELY13Io5Ng3r+ioV0ZLE=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=HniD5Xp5oKaI6IQVcwljTZ5c3sCRxklWFwGEV6xSjNac2r675VQiCeqU+zVVqSgfX
 zWhNmdG+LqOZYGcGQ+QY9bj4u7wIAv7D4mrDMDZbOxZcByDC4eYqLSb3Loe40P6Q/M
 mIlj7Ck5Uk95r29nZX2QMrEVsNgJUe6DjzYY58wE=
Date: Tue, 22 Sep 2020 18:37:13 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKZ5DM6WTQF4D4FS4JV5O2D4TEVBNHHCTNBHWI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4093/review/493970828@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4093@github.com>
References: <quicwg/base-drafts/pull/4093@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: add examples (#4093)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5f6aa6c987f23_5c6719f0350f6";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a0QuXOwir4VAyoNPpFDtuOBV7eQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Sep 2020 01:37:16 -0000


----==_mimepart_5f6aa6c987f23_5c6719f0350f6
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@martinthomson approved this pull request.

This is excellent.  Thanks for adding the one extra reference and the www.example.com.

I didn't check the examples carefully, but I checked a couple and those line up neatly.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4093#pullrequestreview-493970828
----==_mimepart_5f6aa6c987f23_5c6719f0350f6
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@martinthomson</b> approved this pull request.</p>

<p>This is excellent.  Thanks for adding the one extra reference and the <a href="http://www.example.com" rel="nofollow">www.example.com</a>.</p>
<p>I didn't check the examples carefully, but I checked a couple and those line up neatly.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/4093#pullrequestreview-493970828">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2TWXDLSLX3WJCV5GDSHFGMTANCNFSM4RIFNYPA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK5W33HFYLTC4GLBX3DSHFGMTA5CNFSM4RIFNYPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODVYWLDA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/4093#pullrequestreview-493970828",
"url": "https://github.com/quicwg/base-drafts/pull/4093#pullrequestreview-493970828",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5f6aa6c987f23_5c6719f0350f6--

