IETF Logo Mail Archive

Re: [quicwg/base-drafts] Editorial suggestions from Benjamin Kaduk's IESG review (qpack) (#4789)

kaduk <notifications@github.com> Sat, 23 January 2021 01:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 720313A162A for <quic-issues@ietfa.amsl.com>; Fri, 22 Jan 2021 17:40:58 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.803
X-Spam-Level:
X-Spam-Status: No, score=-1.803 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0QW930lTOXX for <quic-issues@ietfa.amsl.com>; Fri, 22 Jan 2021 17:40:57 -0800 (PST)
Received: from smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 046953A0E1B for <quic-issues@ietf.org>; Fri, 22 Jan 2021 17:40:56 -0800 (PST)
Received: from github.com (hubbernetes-node-83aef73.ac4-iad.github.net [10.52.113.55]) by smtp.github.com (Postfix) with ESMTPA id 34285520A84 for <quic-issues@ietf.org>; Fri, 22 Jan 2021 17:40:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1611366056; bh=cu7k5/PzK8qW+1SjJUJPynPLjF/KeiOQ2rSBfG3YYSA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FaDBivJPuoD0osoIPXnLv9CbL7K+FHrL7WsgXFEV0annDcR6tvcDAA1vwRp47IIFd tG6Krg99r4zDremw8+5GjuwIC5A2KKEjn3UbO8wu6zPg/bUXYG+Pbp/t2caxIP1UbJ OKygK5q80xaUeJpynhf/fRWxtzbEOnyyssfpCtfY=
Date: Fri, 22 Jan 2021 17:40:56 -0800
From: kaduk <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYI3AHQTFNI7CR5AGN6C5P2REVBNHHC6HKUTI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4789/review/574721453@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4789@github.com>
References: <quicwg/base-drafts/pull/4789@github.com>
Subject: Re: [quicwg/base-drafts] Editorial suggestions from Benjamin Kaduk's IESG review (qpack) (#4789)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_600b7ea831b94_441a048469a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kaduk
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a1NN-WSVQ0AD158QpX3_7nSmgA8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jan 2021 01:40:58 -0000

@kaduk commented on this pull request.



> +state memory it uses and signal a lower dynamic table size than the decoder
+allows to propagate that fact to the decoder (see {{eviction}}).

Thanks; I pushed that with a slight modification (the signalling is not part of the act of limiting the encoder's state memory, but rather a related but separate act).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4789#discussion_r562998146

v2.23.0 | Report a Bug | By Email