Re: [quicwg/base-drafts] Rework section on persistent congestion (#3961)

Mike Bishop <notifications@github.com> Tue, 11 August 2020 20:24 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1120F3A0C63 for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 13:24:01 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.101
X-Spam-Level:
X-Spam-Status: No, score=-3.101 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id caXcMZYS_Uev for <quic-issues@ietfa.amsl.com>; Tue, 11 Aug 2020 13:23:59 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 2AAA13A0C4A for <quic-issues@ietf.org>; Tue, 11 Aug 2020 13:23:59 -0700 (PDT)
Received: from github-lowworker-1b8c660.ash1-iad.github.net (github-lowworker-1b8c660.ash1-iad.github.net [10.56.18.59]) by smtp.github.com (Postfix) with ESMTP id 161AA5E0F18 for <quic-issues@ietf.org>; Tue, 11 Aug 2020 13:23:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597177438; bh=p3BAR8J69EOpN30fcwwsovTAbxxOIG1nVvIQ4Y0XnGU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HWohSaBn9UcP2cMlwn0loIFyY/bO+PGiCM0vtOpDD4rKKKB98lXKvtbBOmnQh+v+q DoLm+edf8o8JvJmLH7R+F6WoHYuerTrvMkyDAkqh4WOzqDlgm2mZ5mo06CYayYbTwg PfJQKpHATihmOLXMiYBk0DCN75a3U0LrWiQBTLdU=
Date: Tue, 11 Aug 2020 13:23:58 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4FQNQ55MQSSQSJC4N5H3PV5EVBNHHCPPLSJE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3961/review/465397169@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3961@github.com>
References: <quicwg/base-drafts/pull/3961@github.com>
Subject: Re: [quicwg/base-drafts] Rework section on persistent congestion (#3961)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f32fe5e6f9d_383416f826093"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a25LTuvs3xCnuqozLgxX11doCR4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Aug 2020 20:24:01 -0000

@MikeBishop approved this pull request.



> +This duration allows a sender to send as many packets, including some in
+response to PTO expiration, as TCP does with Tail Loss Probe ({{RACK}}), before
+establishing persistent congestion, as TCP does with a Retransmission Timeout
+({{?RFC5681}}).

This many parenthetical phrases in commas is tough to parse.  Can we divide it up a little more?  Into multiple sentences, by using something other than commas, or by condensing?

```suggestion
This duration allows a sender to send as many packets before
establishing persistent congestion, including some in
response to PTO expiration, as TCP does with a Retransmission Timeout
({{?RFC5681}}) and a Tail Loss Probe ({{RACK}}).
```

> +This design does not use consecutive PTO events to establish persistent
+congestion, since application patterns impact PTO expirations. For example, a
+sender that sends small amounts of data with silence periods between them
+restarts the PTO timer every time it sends, potentially preventing the PTO timer
+from expiring for a long period of time, even when no acknowledgments are being
+received. The use of a duration enables a sender to establish persistent
+congestion without depending on the occurrence of PTOs.
+
+### Establishing Persistent Congestion
+
+A sender establishes persistent congestion on receiving an acknowledgement if at
+least two ack-eliciting packets are declared lost, and:
+
+* a prior RTT sample existed when both packets were sent;
+
+* the duration between the send times of these two packets exceeds the

Actually, I might move that third bullet to be first.  Conceptually, it frames the idea that they're the first and last packets of a 2+ packet sequence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3961#pullrequestreview-465397169