Re: [quicwg/base-drafts] Small clarification and one nit (recovery) (#3392)

ianswett <notifications@github.com> Wed, 11 March 2020 05:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D5AD63A1231 for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:43:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.696
X-Spam-Level:
X-Spam-Status: No, score=-6.696 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p6drXBL-XV8z for <quic-issues@ietfa.amsl.com>; Tue, 10 Mar 2020 22:43:20 -0700 (PDT)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 645FF3A08AE for <quic-issues@ietf.org>; Tue, 10 Mar 2020 22:43:20 -0700 (PDT)
Received: from github-lowworker-56fcc46.va3-iad.github.net (github-lowworker-56fcc46.va3-iad.github.net [10.48.102.32]) by smtp.github.com (Postfix) with ESMTP id 1B5BC120F90 for <quic-issues@ietf.org>; Tue, 10 Mar 2020 22:43:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583905400; bh=+Ux90P4kKiQCEOH91J5NYDTu5TdBPIItog9Vu5GGvP0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oIdoeh4AFnRUxQugtK4x0lu8qvKV8k2Zd/cUlQuF7ZC+j0iYkxS21HcTPqcMx/Nvh wJtqnNdRKXLcCY8cA8wmgyt+yrc1dF639GzZOo/PFGQpk7RyxgOjGaENfMPvtFRLQb w/VCpv9RiJBzDS9Gqd7XCZAUPIsMCeVRv+wAg3A4=
Date: Tue, 10 Mar 2020 22:43:19 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYLPN4CJA7A3RKCGJ54ORNXPEVBNHHCCBYAVY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3392/review/372487456@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3392@github.com>
References: <quicwg/base-drafts/pull/3392@github.com>
Subject: Re: [quicwg/base-drafts] Small clarification and one nit (recovery) (#3392)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e687a77ca908_49743ffd5d0cd95c4666aa"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a2OXCWnPaJwLzSivjR1NjVxxTh8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Mar 2020 05:43:22 -0000

ianswett commented on this pull request.



>  When ack-eliciting packets are in-flight in multiple packet number spaces,
 the timer MUST be set for the packet number space with the earliest timeout,
 except for ApplicationData, which MUST be ignored until the handshake
 completes; see Section 4.1.1 of {{QUIC-TLS}}.  Not arming the PTO for
 ApplicationData prioritizes completing the handshake and prevents the server
-from sending a 1-RTT packet on a PTO before before it has the keys to process
-a 1-RTT packet.
+from sending a 1-RTT packet on a PTO before it has the keys to process a 1-RTT

Thanks, fixed in #3486 that landed today.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3392#pullrequestreview-372487456