Re: [quicwg/base-drafts] Clarify crypto context for Connection Close (#1818)

Kazuho Oku <notifications@github.com> Tue, 02 October 2018 01:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57786126CB6 for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 18:04:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OyVjK5TgBA92 for <quic-issues@ietfa.amsl.com>; Mon, 1 Oct 2018 18:04:39 -0700 (PDT)
Received: from out-12.smtp.github.com (out-12.smtp.github.com [192.30.254.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6F55B124C04 for <quic-issues@ietf.org>; Mon, 1 Oct 2018 18:04:39 -0700 (PDT)
Date: Mon, 01 Oct 2018 18:04:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1538442278; bh=DL9ZHdgDRfxBk5zFJl+bp3e30Xk3ZNNKTOHwFDQzkds=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=on9mxarGLeqa//lhw1SxJhVFfMXVRJnCw2m0vezu7SOdjpTH2p3ob7FcIOfFwYNzA f938f8Ro9auFMulDI82E6UCf/Nn0NJSXmp3QyYYmLEkF5NZdO5PgaM18t9KuOPfQMW 5GWnoCM8Z9uyqZBd+/8HJ0DVL2RiwUozQNVV5k8U=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf280d4153cbf843a5946f63be264198b917437e992cf0000000117ca862692a169ce15cb9be3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1818/review/160538484@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1818@github.com>
References: <quicwg/base-drafts/pull/1818@github.com>
Subject: Re: [quicwg/base-drafts] Clarify crypto context for Connection Close (#1818)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bb2c4267738f_1e23f99532d45c0667d8"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/a8mqYCHz_qI_cwNtFYxibGmlDIs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2018 01:04:41 -0000

kazuho commented on this pull request.



> @@ -2606,6 +2606,16 @@ An endpoint sends a closing frame (CONNECTION_CLOSE or APPLICATION_CLOSE) to
 terminate the connection immediately.  Any closing frame causes all streams to
 immediately become closed; open streams can be assumed to be implicitly reset.
 
+If the endpoint has successfully decrypted a 1-RTT packet from its peer, it
+SHOULD send CONNECTION_CLOSE in a 1-RTT packet. If not, and it has received a

This does not work if the client decides to abort the handshake in response to the server's Handshake messages, because the server's messages typically end with NewSessionTicket carried by a 1-RTT packet but the server cannot decrypt a 1-RTT packet from client until it receives ClientFinished.

IMO, we should state that an endpoint SHOULD send CONNECTION_CLOSE using a Handshake packet until either of the following to condition is met: a) it knows that the peer can decrypt a 1-RTT packet, b) it drops the Handshake keys based on the timer.

Other than that, the PR looks good to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1818#pullrequestreview-160538484