Re: [quicwg/base-drafts] Editorial proposed changes for cc section (#3491)

Martin Thomson <notifications@github.com> Tue, 03 March 2020 22:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 808EA3A0776 for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 14:56:27 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.1
X-Spam-Level:
X-Spam-Status: No, score=-3.1 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iMGzJLnv2tSy for <quic-issues@ietfa.amsl.com>; Tue, 3 Mar 2020 14:56:25 -0800 (PST)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ADB8F3A0768 for <quic-issues@ietf.org>; Tue, 3 Mar 2020 14:56:25 -0800 (PST)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 8F5338C0D5A for <quic-issues@ietf.org>; Tue, 3 Mar 2020 14:56:24 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1583276184; bh=mbi1aJXTT0Q7QL117h+s/qApl14ZRmBwALv7vqGybnk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pT/8ZFieIjXhEwis5YpYPqd0GH0Gi8zvPd5cQgIn2c8zkJRllvFjT6bO8ueDeq2Y5 gH5aAzXCRtxtHGQYo8JBfUsR61vQGO7DyuKGsalm/RKE4UhuKpfr6e1e4qcXQTKVT4 tn102xTpD6R2TRLskv6BafbEMMjT8tn5F8vNNv08=
Date: Tue, 03 Mar 2020 14:56:24 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7BGE4ICVPYJ77VI4N4NLAZREVBNHHCEP5FGU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3491/review/368386188@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3491@github.com>
References: <quicwg/base-drafts/pull/3491@github.com>
Subject: Re: [quicwg/base-drafts] Editorial proposed changes for cc section (#3491)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e5ee0987ea32_abb3fd4320cd9601464a0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aDfwXEGaiv9DlUcf7hHafjmri9s>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Mar 2020 22:56:28 -0000

martinthomson approved this pull request.

A few typos and one tiny regression, but these are good changes.

>  
 ## Recovery Period
 
 A recovery period is entered when loss or ECN-CE marking of a packet is
-detected.  A recovery period ends when a packet sent during the recovery period
-is acknowledged.  This is slightly different from TCP's definition of recovery,
-which ends when the lost packet that started recovery is acknowledged.
+detected in congestion aviodance but after the congestion wiondow and slow

```suggestion
detected in congestion avoidance but after the congestion window and slow
```

>  
 ## Recovery Period
 
 A recovery period is entered when loss or ECN-CE marking of a packet is
-detected.  A recovery period ends when a packet sent during the recovery period
-is acknowledged.  This is slightly different from TCP's definition of recovery,
-which ends when the lost packet that started recovery is acknowledged.
+detected in congestion aviodance but after the congestion wiondow and slow
+start threhold has been adapted.  A recovery period ends when a packet sent

```suggestion
start threshold has been adapted.  A recovery period ends when a packet sent
```

>  
 ## Recovery Period
 
 A recovery period is entered when loss or ECN-CE marking of a packet is
-detected.  A recovery period ends when a packet sent during the recovery period
-is acknowledged.  This is slightly different from TCP's definition of recovery,
-which ends when the lost packet that started recovery is acknowledged.
+detected in congestion aviodance but after the congestion wiondow and slow
+start threhold has been adapted.  A recovery period ends when a packet sent

adapted how?

> @@ -766,17 +768,18 @@ similar to a sender's response on a Retransmission Timeout (RTO) in TCP
 
 ## Pacing {#pacing}
 
-This document does not specify a pacer, but it is RECOMMENDED that a sender pace
+This document does not specify a pacer, but it is RECOMMENDED that a sender paces

```suggestion
This document does not specify a pacer, but it is RECOMMENDED that a sender pace
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3491#pullrequestreview-368386188