Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 69DC1130DD1
 for <quic-issues@ietfa.amsl.com>; Fri, 29 Jun 2018 09:01:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level: 
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
 DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01]
 autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id y8Ytk_JSkQIE for <quic-issues@ietfa.amsl.com>;
 Fri, 29 Jun 2018 09:01:14 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 5DCA6130DD8
 for <quic-issues@ietf.org>; Fri, 29 Jun 2018 09:01:14 -0700 (PDT)
Date: Fri, 29 Jun 2018 09:01:13 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1530288073;
 bh=M5bfIEurnat4elPbr0rgZgI5+EmxaCcQ3l9wPd4bXNQ=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=yEy/wC3Suvf6+AtjmGC7Zg5DGsC+nclfif5K5Tca8sTSNU2r7HfQcCt7vG16j25lm
 e+MaPBawHplWJE/lYRC6995ZCtuMZ9zWhzHmKc0q1H+6Hz3sAOyUU+DdOl3UVvk4iR
 D5DJiK8dd47WSV4g7vu/34AtTH+YN6NuhiZrSo84=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abe45b5f22450bf06e9ad1bbe36800d94acb1f84be92cf00000001174e19c992a169ce1414837f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1501/review/133285426@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1501@github.com>
References: <quicwg/base-drafts/pull/1501@github.com>
Subject: Re: [quicwg/base-drafts] Define NAT rebinding better (#1501)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5b3657c9bb7c7_5eb72aedf03e0f5421352f";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aFMu-wo9x1M2mS6TOkM6XYYA_aw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jun 2018 16:01:17 -0000


----==_mimepart_5b3657c9bb7c7_5eb72aedf03e0f5421352f
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> -note that not all changes of peer address are intentional migrations. The peer
-could experience an unintended change of address due to NAT rebinding; endpoints
-SHOULD perform path validation ({{migrate-validate}}) if the rebinding does not
-cause the connection to fail.
+finished and the endpoint has 1-RTT keys.  The design of QUIC relies on
+endpoints retaining a stable address for the duration of the handshake.
+
+An endpoint also MUST NOT initiate connection migration if the peer sent the
+`disable_migration` transport parameter during the handshake.  An endpoint which
+has sent this transport parameter, but detects that a peer has nonetheless
+migrated to a different network MAY treat this as a connection error of type
+INVALID_MIGRATION.
+
+Not all changes of peer address are intentional migrations. The peer could
+experience NAT rebinding: a change of address due a middlebox, usually a NAT,
+allocating a new outgoing IP address and port for a flow.  Endpoints SHOULD

IP address and/or port?  Typically NAT rebinds are only port change.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426
----==_mimepart_5b3657c9bb7c7_5eb72aedf03e0f5421352f
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/1501#discussion_r199207061">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; -note that not all changes of peer address are intentional migrations. The peer
-could experience an unintended change of address due to NAT rebinding; endpoints
-SHOULD perform path validation ({{migrate-validate}}) if the rebinding does not
-cause the connection to fail.
+finished and the endpoint has 1-RTT keys.  The design of QUIC relies on
+endpoints retaining a stable address for the duration of the handshake.
+
+An endpoint also MUST NOT initiate connection migration if the peer sent the
+`disable_migration` transport parameter during the handshake.  An endpoint which
+has sent this transport parameter, but detects that a peer has nonetheless
+migrated to a different network MAY treat this as a connection error of type
+INVALID_MIGRATION.
+
+Not all changes of peer address are intentional migrations. The peer could
+experience NAT rebinding: a change of address due a middlebox, usually a NAT,
+allocating a new outgoing IP address and port for a flow.  Endpoints SHOULD
</pre>
<p>IP address and/or port?  Typically NAT rebinds are only port change.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq7jDR9Dh-5tZNCraJPXVqHawwEoPks5uBk9JgaJpZM4U8jDb">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq5EQR6H5dn6XL7psznXnPf2iWcILks5uBk9JgaJpZM4U8jDb.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #1501"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426",
"url": "https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ianswett commented on 1501",
"sections": [
{
"text": "",
"activityTitle": "**ianswett**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ianswett",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/quicwg/base-drafts/pull/1501#pullrequestreview-133285426"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 351416539\n}"
}
],
"themeColor": "26292E"
}
]</script>
----==_mimepart_5b3657c9bb7c7_5eb72aedf03e0f5421352f--

