IETF Logo Mail Archive

Re: [quicwg/base-drafts] Handling of duplicate packets (#1405)

Kazuho Oku <notifications@github.com> Thu, 31 May 2018 23:48 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 528C612D93E for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 16:48:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RqI4roxV14MD for <quic-issues@ietfa.amsl.com>; Thu, 31 May 2018 16:48:21 -0700 (PDT)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 29EA412D872 for <quic-issues@ietf.org>; Thu, 31 May 2018 16:47:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=gQx149giFjUSzEvLyM1AgEt7k2k=; b=fMrMhLwL3xkNZ5JT NbbR6aKFvDSMkwl30g9bx6sEqCRAaiUy6JmzxRpPJDJ9OS26Gj5LUCdmzar1TlrB iglWl3QMswUSr83WRIvOSHvJnZ9SRltePDT6djs0Pn2VQBP9/gld8DzxUavs7ReR 9ERPkRqtZLVxOTJfhe+vMikKMls=
Received: by filter1372p1mdw1.sendgrid.net with SMTP id filter1372p1mdw1-3538-5B108995-7 2018-05-31 23:47:33.249947165 +0000 UTC
Received: from github-lowworker-0be93ae.cp1-iad.github.net (unknown [192.30.252.33]) by ismtpd0010p1iad1.sendgrid.net (SG) with ESMTP id plELOPHyQjOh3KTYD4E-sQ for <quic-issues@ietf.org>; Thu, 31 May 2018 23:47:33.151 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0be93ae.cp1-iad.github.net (Postfix) with ESMTP id 226BF3E0A45 for <quic-issues@ietf.org>; Thu, 31 May 2018 16:47:33 -0700 (PDT)
Date: Thu, 31 May 2018 23:47:33 +0000
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab797546f4a8f8c90c4e397aece0d96fd04a42203392cf0000000117284b9592a169ce138d6870@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1405/393716871@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1405@github.com>
References: <quicwg/base-drafts/issues/1405@github.com>
Subject: Re: [quicwg/base-drafts] Handling of duplicate packets (#1405)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b108995215bd_2a7143f8414bcaf842830e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1yCHBqzJh1bteCnrcw11PSvXToaBwF8GFUUD zIpN4KBMMTK50eOCdUxfZerGmPWl7UbRJ1zd+HIwm3PjFXIF7LZGyD8RtWHx1X+ZLdFUvXqRXxUnaR DR9z9qVh4c+mY8xwxckw6lyxo8bSfiKrubObCfJI0TGjDQBgmOdn1Lp+GAUyUItPY3r4+6tl1R7QoM I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aGOFXD_747x9aQqq530Gwxp0e48>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 23:48:32 -0000

> One thing we need to observe is that we won't be checking that the packet is a true duplicate, only that we've (probably) seen the (apparent) packet number before.

:+1:

I would like to argue that, the QUIC protocol needs to and will have idempotency against receiving and processing duplicate packets, and that checking for a duplicate should not be a requirement of the protocol.

Regarding the effect to ECN, I tend to think that processing of duplicates at an endpoint is an orthogonal issue to ECN, because both ECN-CE-marked and non-marked packets have the chance of binge dropped or duplicated.

IMO, the requirement in ECN support should be to state that the ECN counters (i.e. ECN(0), ECN(1), ECN-CE) must be updated _prior to_ processing the packet (e.g., decryption, duplicate detection). Then, the sender can get the most information for adjusting the congestion control.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1405#issuecomment-393716871

v2.31.3 | Report a Bug | By Email | System Status