Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)

ianswett <> Tue, 19 November 2019 14:59 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 8A81C12083D for <>; Tue, 19 Nov 2019 06:59:39 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 9eMvRsv4duR4 for <>; Tue, 19 Nov 2019 06:59:37 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 9A9821200F5 for <>; Tue, 19 Nov 2019 06:59:37 -0800 (PST)
Date: Tue, 19 Nov 2019 06:59:36 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1574175576; bh=QGBejmsMne8iUhcaqcmXnGBsFGrvlQ4ur6FaRnjLoXY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zueaPY88+Ve7X9i7xyoePRnTW6zd8lqgmxWPlSfGs7yzLD5wO9k3/BkRTBADIY2gb khErRZOFi1V+5nK7mo2WpplWZtRjlFBwRseYWgTv6ADCtKQzOz2jxDhmoVpzKwznDW 4zMwR7J9b2VP+/7NnORfhAgDzxFp000BbY+PGx8k=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3047/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Send after receiving an ACK (#3047)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd40358aa629_283b3f841a2cd96c18305f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Tue, 19 Nov 2019 14:59:40 -0000

ianswett commented on this pull request.

> @@ -1031,9 +1031,10 @@ OnAckReceived(ack, pn_space):
     OnPacketAcked(acked_packet.packet_number, pn_space)
+  // Immediately attempt to send, but never more than the
+  // initial window in a single burst.
+  SendUpToIWPacketsAsCongestionControllerAllows()

The intent is is not to send a burst, but rather to limit any sending to the IW, as specified in the normative text: 

"Implementations MUST either use pacing or limit such bursts to the initial congestion window, which is recommended to be the minimum of 10 * max_datagram_size and max(2* max_datagram_size, 14720)), where max_datagram_size is the current maximum size of a datagram for the connection, not including UDP or IP overhead."

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: