IETF Logo Mail Archive

Re: [quicwg/base-drafts] Optimize definition IP addr in TP PreferredAddress (#1533)

Mike Bishop <notifications@github.com> Fri, 06 July 2018 22:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A0000130F2D for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 15:27:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4D9RlnM9a4Zq for <quic-issues@ietfa.amsl.com>; Fri, 6 Jul 2018 15:27:43 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E20E4130DD6 for <quic-issues@ietf.org>; Fri, 6 Jul 2018 15:27:42 -0700 (PDT)
Date: Fri, 06 Jul 2018 15:27:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530916061; bh=+IAGT5enHgSRrJYN2/DRMbxiZX0+EYsjMB41TzScrX0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Ky/+l06KXnA6idkrVMm79p2tDMTo61Cr0/A6DJgJ/b9miGDDk4HAwDZ8ic5eCYIE3 y8kCXk5mN6PJqtQ6F1D+3+zGYLB1ufmrnMEhSeEUnBkToNlIIMm209+lZyh1fvz/zp d3yv3TrvVa0mica3wJUkE68xA4pPAXkm4KWSlHfY=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abccec1be22a12cb72f37c83169676ddfadd225a4a92cf000000011757aedd92a169ce1435a6cc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1533/c403161657@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1533@github.com>
References: <quicwg/base-drafts/pull/1533@github.com>
Subject: Re: [quicwg/base-drafts] Optimize definition IP addr in TP PreferredAddress (#1533)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3fecddcaba1_22092afc22bd6f5c336f4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aHGRWsCVIWgjHhQz_P_O8ZoVQSo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Jul 2018 22:27:45 -0000

Technically, it's not a string, it's a length-prefixed sequence of bytes.  I think all this actually does is to make the length implicit from the IP version.  @martinthomson had suggested having the explicit length prefix, so I'll invoke him to defend it.  ;-)

Making it implicit saves a byte, if nothing else. If you see an IP version you don't recognize (and therefore don't know how long the following field is), you're probably bailing on the entire TP anyway.  Fortunately, the value is also length-prefixed and could be skipped as a whole.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1533#issuecomment-403161657

v2.46.0 | Report a Bug | By Email | System Status