Re: [quicwg/base-drafts] MAY send 1 packet entering recovery (#3443)

Jana Iyengar <notifications@github.com> Tue, 11 February 2020 23:29 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AA95F120838 for <quic-issues@ietfa.amsl.com>; Tue, 11 Feb 2020 15:29:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Y_Vt2dIY3EJU for <quic-issues@ietfa.amsl.com>; Tue, 11 Feb 2020 15:29:06 -0800 (PST)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4329912004C for <quic-issues@ietf.org>; Tue, 11 Feb 2020 15:29:06 -0800 (PST)
Received: from github-lowworker-cd7bc13.ac4-iad.github.net (github-lowworker-cd7bc13.ac4-iad.github.net [10.52.25.102]) by smtp.github.com (Postfix) with ESMTP id 61289A0C31 for <quic-issues@ietf.org>; Tue, 11 Feb 2020 15:29:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581463745; bh=OB3q5iXP7zk6qnWwXazmLTZFjlQ5f85vjOD3Y3jdnuA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=b1C4KSTiSai+riaBUCc+fgZ8NR3+BV83vTED60AVRVHvnCro3Sbk1UgaCAf+u4P10 M7x54Zsc8CKYAKn6foSTVfvX1rwyfYLaxZeUR+0CDH+EF2+w/m4qoiEG6B1+1Odg4u D+Wpmam6PyjrIDEvJNvXWpU81hat2siYqqr59CTs=
Date: Tue, 11 Feb 2020 15:29:05 -0800
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4IHEA4UOSY6CTOCB54KBVUDEVBNHHCDAQ2C4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3443/review/357071802@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3443@github.com>
References: <quicwg/base-drafts/pull/3443@github.com>
Subject: Re: [quicwg/base-drafts] MAY send 1 packet entering recovery (#3443)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4338c14fdaa_646e3fe9e8acd96c171644"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/aHsfK1Uo1An0ufbaDnX2eiNUp6k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Feb 2020 23:29:09 -0000

janaiyengar approved this pull request.

Just a nit, but LGTM.

> @@ -687,6 +687,12 @@ The recovery period limits congestion window reduction to once per round trip.
 During recovery, the congestion window remains unchanged irrespective of new
 losses or increases in the ECN-CE counter.
 
+When entering recovery, a single packet MAY be sent even if bytes in flight
+now exceeds the recently reduced congestion window.  This speeds up loss
+recovery if the data in the lost packet is retransmitted and is similar to TCP
+as described in Section 5 of {{?RFC6675}}.  If further packets are lost after
+already in recovery, the congestion window MUST be observed as normal.

nit: "If further packets are lost while the sender is in recovery, sending any packets in response MUST obey the congestion window limit."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3443#pullrequestreview-357071802